implemented the proposed resolution for LWG-2762

[Omar (OmarSaber98)]

Fixes #2257

[Deleted user (ghost)]

All CLA requirements met.

[Casey Carter (CaseyCarter)]

We need a bit of test coverage - basically just a static_assert(noexcept(meow)) where meow is a call to each of these functions. Otherwise this looks great.

[Stephan T. Lavavej (StephanTLavavej)]

Thanks! I went ahead and pushed comment changes to the test, as it had commented-out lines like // ASSERT_NOT_NOEXCEPT(*opt); (explaining why libcxx couldn't test that, due to their GCC coverage) which are being completely superseded by your STATIC_ASSERTs that these expressions are now required to be noexcept. FYI Casey Carter (@CaseyCarter).

[Omar (OmarSaber98)]

I tried running the tests on compiler explorer before committing and on the latest msvc the tests were failing with /std:c++latest and /std:c++20 flags but was confused when i found that with /std:c++17 flag the tests were passing.

A reproduction of that can be found here: https://compiler-explorer.com/z/eGbjYof3M

[Alex Guteniev (AlexGuteniev)]

A reproduction of that can be found here: https://compiler-explorer.com/z/eGbjYof3M

/permissive effect. Default of /permissive is different.
Add /permissive- to C++17 to make it fail or add /permissive to C++20 to make it pass.

[Stephan T. Lavavej (StephanTLavavej)]

I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed.

[Stephan T. Lavavej (StephanTLavavej)]

Thanks for implementing this LWG issue resolution, and congratulations on your second microsoft/STL commit! 😻 ✨ 🚀

This will ship in VS 2022 17.2 Preview 2.