Implement LWG-3590: split_view::base() const & is overconstrained - #2404
Merged
Stephan T. Lavavej (StephanTLavavej) merged 5 commits intoDec 17, 2021
Merged
Conversation
Michael Schellenberger Costa (miscco)
approved these changes
Dec 11, 2021
Michael Schellenberger Costa (miscco)
left a comment
Contributor
There was a problem hiding this comment.
Mostly nitpicks
Igor Zhukov (fsb4000)
force-pushed
the
fix2400
branch
from
December 11, 2021 19:05
d42cfca to
9909956
Compare
Igor Zhukov (fsb4000)
force-pushed
the
fix2400
branch
from
December 11, 2021 19:08
9909956 to
0ac79c3
Compare
Co-authored-by: Michael Schellenberger Costa <mschellenbergercosta@gmail.com>
split_view::base() const & is overconstrained
Stephan T. Lavavej (StephanTLavavej)
approved these changes
Dec 14, 2021
Casey Carter (CaseyCarter)
approved these changes
Dec 16, 2021
Casey Carter (CaseyCarter)
left a comment
Contributor
There was a problem hiding this comment.
I've pushed a fix for my comments.
Stephan T. Lavavej (StephanTLavavej)
approved these changes
Dec 16, 2021
Member
|
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
Member
|
Thanks for implementing this LWG issue resolution! 🚀 🎉 😺 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2400