Implement LWG-3557: The static_cast expression in convertible_to has the wrong operand - #2406
Merged
Stephan T. Lavavej (StephanTLavavej) merged 3 commits intoDec 17, 2021
Merged
Conversation
Michael Schellenberger Costa (miscco)
approved these changes
Dec 11, 2021
Co-authored-by: Michael Schellenberger Costa <mschellenbergercosta@gmail.com>
Sam Huang (celonymire)
approved these changes
Dec 11, 2021
static_cast expression in convertible_to has the wrong operand
Stephan T. Lavavej (StephanTLavavej)
approved these changes
Dec 14, 2021
Casey Carter (CaseyCarter)
approved these changes
Dec 16, 2021
Casey Carter (CaseyCarter)
left a comment
Contributor
There was a problem hiding this comment.
For posterity: I'm fine accepting this without test changes because the before and after conditions have equivalent observable behavior. This change is really a specification tweak masquerading as a change in product code.
Member
|
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
Member
|
Thanks for implementing another LWG issue resolution! 🚀 🚀 😻 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2394