Implement LWG-3574 and LWG-3595: common_iterator should be completely constexpr-able - #2410
Merged
Stephan T. Lavavej (StephanTLavavej) merged 9 commits intoDec 17, 2021
Merged
Conversation
Alex Guteniev (AlexGuteniev)
approved these changes
Dec 12, 2021
Michael Schellenberger Costa (miscco)
approved these changes
Dec 12, 2021
Stephan T. Lavavej (StephanTLavavej)
approved these changes
Dec 14, 2021
Member
|
Thanks! I added a missing |
common_iterator should be completely constexpr-ablecommon_iterator should be completely constexpr-able
Igor Zhukov (fsb4000)
requested a review
from Stephan T. Lavavej (StephanTLavavej)
December 14, 2021 16:22
Contributor
When the Working Draft says |
Casey Carter (CaseyCarter)
suggested changes
Dec 14, 2021
Casey Carter (CaseyCarter)
approved these changes
Dec 14, 2021
common_iterator should be completely constexpr-ablecommon_iterator should be completely constexpr-able
Stephan T. Lavavej (StephanTLavavej)
approved these changes
Dec 15, 2021
Test constexpr copy construction with a stored sentinel whose copy constructor is constexpr but not trivial
Stephan T. Lavavej (StephanTLavavej)
approved these changes
Dec 15, 2021
Member
|
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
Member
|
Thanks for implementing a fourth and fifth LWG issue resolution in today's batch! 🤯 💥 😻 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2397
Fixes #2264