Skip to content

Implement LWG-3571 and LWG-3570: flush_emit set badbit if the emit call fails - #2418

Merged
Stephan T. Lavavej (StephanTLavavej) merged 18 commits into
microsoft:mainfrom
fsb4000:fix2396
Mar 17, 2022
Merged

Implement LWG-3571 and LWG-3570: flush_emit set badbit if the emit call fails#2418
Stephan T. Lavavej (StephanTLavavej) merged 18 commits into
microsoft:mainfrom
fsb4000:fix2396

Conversation

@fsb4000

@fsb4000 Igor Zhukov (fsb4000) commented Dec 14, 2021 •
edited
Loading

Copy link
Copy Markdown
Contributor

Fixes #2396

Fixes #2395

@fsb4000
Igor Zhukov (fsb4000) requested a review from a team as a code owner December 14, 2021 14:26
@fsb4000 @miscco
better name for output stream state
a6596d5 
Co-authored-by: Michael Schellenberger Costa <mschellenbergercosta@gmail.com>
@StephanTLavavej Stephan T. Lavavej (StephanTLavavej) added the LWG Library Working Group issue label Dec 15, 2021
StephanTLavavej
Stephan T. Lavavej (StephanTLavavej) requested changes Dec 15, 2021
View reviewed changes
Comment thread stl/inc/ostream Outdated
@fsb4000 Igor Zhukov (fsb4000) changed the title Implement LWG-3571: flush_emit set badbit if the emit call fails Implement LWG-3571 and LWG-3570: flush_emit set badbit if the emit call fails Dec 15, 2021
@fsb4000

This comment has been minimized.

Sign in to view
MattStephanson
Matt Stephanson (MattStephanson) suggested changes Dec 16, 2021
View reviewed changes
Comment thread stl/inc/syncstream Outdated
Comment thread stl/inc/ostream Outdated
Igor Zhukov (fsb4000) and others added 4 commits December 16, 2021 09:39
@fsb4000 @MattStephanson
correct sentries usage
4ecbb31 
Co-authored-by: Matt Stephanson <stephanson.matt@gmail.com>
@fsb4000 @MattStephanson
add tests
c08e789 
Co-authored-by: Matt Stephanson <stephanson.matt@gmail.com>
@fsb4000
add more tests
797fc67
@fsb4000
add lwg descriptions
ba291d9
MattStephanson
Matt Stephanson (MattStephanson) approved these changes Dec 23, 2021
View reviewed changes

@MattStephanson Matt Stephanson (MattStephanson) left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

StephanTLavavej
Stephan T. Lavavej (StephanTLavavej) reviewed Feb 23, 2022
View reviewed changes
Comment thread tests/std/tests/P0753R2_manipulators_for_cpp_synchronized_buffered_ostream/test.cpp Outdated
Comment thread stl/inc/syncstream Outdated
Comment thread tests/std/tests/P0753R2_manipulators_for_cpp_synchronized_buffered_ostream/test.cpp Outdated
Comment thread tests/std/tests/P0753R2_manipulators_for_cpp_synchronized_buffered_ostream/test.cpp Outdated
Comment thread tests/std/tests/P0753R2_manipulators_for_cpp_synchronized_buffered_ostream/test.cpp Outdated
@StephanTLavavej

Stephan T. Lavavej (StephanTLavavej) commented Feb 23, 2022

Copy link
Copy Markdown
Member

Thanks, this looks solid! The only things I noticed were stylistic nitpicks, so I went ahead and pushed a merge with main followed by those trivial changes, after validating that the relevant tests still pass.

barcharcraz
Charlie Barto (barcharcraz) suggested changes Mar 10, 2022
View reviewed changes
Comment thread stl/inc/syncstream
if (!_Ok) {
_State |= ios_base::badbit;
} else {
_TRY_IO_BEGIN

@barcharcraz Charlie Barto (barcharcraz) Mar 10, 2022

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

God I really don't like these, it's pre-existing (and changing it would be ... a project) so don't consider this a change request, but maybe we should open an issue.

Comment thread tests/std/tests/P0753R2_manipulators_for_cpp_synchronized_buffered_ostream/test.cpp Outdated
Igor Zhukov (fsb4000) and others added 2 commits March 10, 2022 17:12
@fsb4000 Charlie Barto
move the ternary operator out of the assert
0c4f216 
Co-authored-by: Charlie Barto <chbarto@microsoft.com>
@fsb4000
Merge branch 'main' into fix2396
1aa180a
@StephanTLavavej

Stephan T. Lavavej (StephanTLavavej) commented Mar 11, 2022

Copy link
Copy Markdown
Member

Thanks - I approve of the ternary-to-if change that Charlie Barto (@barcharcraz) requested, as if this test ever fails, the asserting line will indicate what was expected - same as the rationale for preferring assert(is_cute()); assert(is_fluffy()); assert(is_kitten()); on separate lines instead of assert(is_cute() && is_fluffy() && is_kitten());.

@barcharcraz Charlie Barto (barcharcraz) removed their assignment Mar 12, 2022
@StephanTLavavej

Stephan T. Lavavej (StephanTLavavej) commented Mar 15, 2022

Copy link
Copy Markdown
Member

I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed.

@StephanTLavavej
Stephan T. Lavavej (StephanTLavavej) merged commit e6fa258 into microsoft:main Mar 17, 2022
@StephanTLavavej

Stephan T. Lavavej (StephanTLavavej) commented Mar 17, 2022

Copy link
Copy Markdown
Member

Thanks for syncing the implementation with the Standard's stream of LWG issues! 😹 🚀 🎉

@fsb4000
Igor Zhukov (fsb4000) deleted the fix2396 branch March 17, 2022 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@StephanTLavavej Stephan T. Lavavej (StephanTLavavej) StephanTLavavej approved these changes
+3 more reviewers
@miscco Michael Schellenberger Costa (miscco) miscco left review comments
@barcharcraz Charlie Barto (barcharcraz) barcharcraz approved these changes
@MattStephanson Matt Stephanson (MattStephanson) MattStephanson approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@StephanTLavavej Stephan T. Lavavej (StephanTLavavej)

Labels

LWG Library Working Group issue

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

LWG-3571 flush_emit should set badbit if the emit call fails LWG-3570 basic_osyncstream::emit should be an unformatted output function

5 participants

@fsb4000 @StephanTLavavej @barcharcraz @miscco @MattStephanson