Skip to content

Remove some strengthened comments - #2448

Merged
Stephan T. Lavavej (StephanTLavavej) merged 1 commit into
microsoft:mainfrom
pjessesco:main
Jan 20, 2022
Merged

Remove some strengthened comments #2448
Stephan T. Lavavej (StephanTLavavej) merged 1 commit into
microsoft:mainfrom
pjessesco:main

Conversation

@pjessesco

Copy link
Copy Markdown
Contributor

Fixes #2403

@pjessesco
jino (pjessesco) requested a review from a team as a code owner December 27, 2021 10:11

@fsb4000 Igor Zhukov (fsb4000) left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: constexpr default_sentinel_t end() const noexcept doesn't have strengthened comment, so we don't remove the comment here.

STL/stl/inc/ranges

Lines 3513 to 3515 in 303df3d

_NODISCARD constexpr default_sentinel_t end() const noexcept {
return default_sentinel;
}

@mnatsuhara

Copy link
Copy Markdown
Contributor

Thanks for your contribution! Many of the maintainers are currently "out of the (virtual) office" due to the end-of-the-year US holidays, so it may take us a little longer to review your changes due to reduced bandwidth. Thanks for your patience, we'll take a look as soon as we can! 😄

@CaseyCarter Casey Carter (CaseyCarter) added the documentation Related to documentation or comments label Dec 29, 2021
@StephanTLavavej

Copy link
Copy Markdown
Member

I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed.

@StephanTLavavej
Stephan T. Lavavej (StephanTLavavej) merged commit 086b072 into microsoft:main Jan 20, 2022
@StephanTLavavej

Copy link
Copy Markdown
Member

Thanks for updating these comments to align with the current Working Paper - and congratulations on your first microsoft/STL commit! 🚀 😸 ✅

This will appear in VS 2022 17.2 Preview 2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Related to documentation or comments LWG Library Working Group issue

Projects

None yet

Development

Successfully merging this pull request may close these issues.

LWG-3593 Several iterators' base() const & and lazy_split_view::outer-iterator::value_type::end() missing noexcept

5 participants