Skip to content

<filesystem>: path should be range - #2457

Merged
Stephan T. Lavavej (StephanTLavavej) merged 14 commits into
microsoft:mainfrom
fsb4000:fix2358
Mar 28, 2022
Merged

Stephan T. Lavavej (StephanTLavavej) merged 14 commits into
microsoft:mainfrom
fsb4000:fix2358

Conversation

@fsb4000

Copy link
Copy Markdown
Contributor

Fixes #2358

@fsb4000
Igor Zhukov (fsb4000) requested a review from a team as a code owner January 4, 2022 14:56
Comment thread stl/inc/filesystem Outdated
Comment thread stl/inc/filesystem Outdated
@CaseyCarter Casey Carter (CaseyCarter) added bug Something isn't working ranges C++20/23 ranges labels Jan 6, 2022
Comment thread tests/std/tests/P0896R4_ranges_test_machinery/test.compile.pass.cpp Outdated

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I pushed changes for my comments, which are a bit more invasive than I'd typically do in someone's branch without asking. Feel free to pushback if you disagree with anything.

Comment thread stl/inc/filesystem Outdated
Comment thread stl/inc/filesystem Outdated
@CaseyCarter Casey Carter (CaseyCarter) removed their assignment Mar 24, 2022
@StephanTLavavej

This comment was marked as resolved.

@azure-pipelines

This comment was marked as resolved.

1 similar comment
@azure-pipelines

This comment was marked as resolved.

@StephanTLavavej

Copy link
Copy Markdown
Member

I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed.

@StephanTLavavej
Stephan T. Lavavej (StephanTLavavej) merged commit c302187 into microsoft:main Mar 28, 2022
@StephanTLavavej

Copy link
Copy Markdown
Member

Thanks for fixing path to behave properly after this surprising interaction with C++23! 😻 🚀 ✅

@fsb4000
Igor Zhukov (fsb4000) deleted the fix2358 branch March 29, 2022 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working ranges C++20/23 ranges

Projects

None yet

Development

Successfully merging this pull request may close these issues.

<filesystem>: path's comparison operators are IF-NDR

4 participants