gcd/lcm test from internal repo with questionable bits extracted - #2507
Merged
Stephan T. Lavavej (StephanTLavavej) merged 2 commits intoFeb 1, 2022
Merged
Conversation
Casey Carter (CaseyCarter)
force-pushed
the
gcdlcm
branch
from
January 27, 2022 20:50
0b7a1b7 to
182f42e
Compare
Casey Carter (CaseyCarter)
marked this pull request as ready for review
January 27, 2022 20:51
Stephan T. Lavavej (StephanTLavavej)
approved these changes
Jan 28, 2022
Member
|
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
Charlie Barto (barcharcraz)
approved these changes
Feb 1, 2022
Charlie Barto (barcharcraz)
left a comment
Contributor
There was a problem hiding this comment.
do we prefer the test.compile.pass.cpp format over just test.cpp now?
Contributor
Author
Yes we do. The GitHub test runner recognizes the suffix |
Member
|
One note about |
Member
|
Thanks for being the Greatest Casey Denominator! 😹 🔼 🎉 |
25 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Partially addresses VSO-936680