resize_and_overwrite: fix warning C4018 - #2525
Merged
Stephan T. Lavavej (StephanTLavavej) merged 2 commits intoFeb 12, 2022
Merged
Conversation
Contributor
|
|
Co-authored-by: PowerGamer1 <PowerGamer1@users.noreply.github.com>
Alex Guteniev (AlexGuteniev)
approved these changes
Feb 7, 2022
Stephan T. Lavavej (StephanTLavavej)
approved these changes
Feb 8, 2022
Comment on lines
+2387
to
+2388
| void test_gh_2524() // COMPILE-ONLY | ||
| { |
There was a problem hiding this comment.
No change requested (mega-nitpick, not worth resetting testing): This brace should be attached to the function. (clang-format would ordinarily fix this, but it's inhibited from doing so by the comment.)
Member
|
I'm mirroring this to the MSVC-internal repo. Requesting or pushing changes is totally fine, but please notify me if that happens. |
Casey Carter (CaseyCarter)
approved these changes
Feb 11, 2022
Member
|
Thanks for fixing this warning! 🎉 😸 ✅ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2524
cmp_less_equalis inutilityxutilityincludesutilityxmemoryincludesxutilityxstringincludesxmemory