Implement P2441R2 views::join_with - #2619
Merged
Stephan T. Lavavej (StephanTLavavej) merged 15 commits intoJun 20, 2022
Merged
Conversation
S. B. Tam (cpplearner)
force-pushed
the
join_with
branch
from
March 28, 2022 08:40
3d3c83e to
41b16ac
Compare
S. B. Tam (cpplearner)
force-pushed
the
join_with
branch
from
March 28, 2022 09:55
41b16ac to
1c3cb80
Compare
Co-authored-by: Michael Schellenberger Costa <mschellenbergercosta@gmail.com>
Co-authored-by: Michael Schellenberger Costa <mschellenbergercosta@gmail.com>
Co-authored-by: Michael Schellenberger Costa <mschellenbergercosta@gmail.com>
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
Michael Schellenberger Costa (miscco)
left a comment
Contributor
There was a problem hiding this comment.
I have some question about the use of _Throw_bad_variant_access whether this is a valid use case here.
I would like to get some feedback on that
Stephan T. Lavavej (StephanTLavavej)
requested changes
Apr 1, 2022
This comment was marked as resolved.
This comment was marked as resolved.
S. B. Tam (cpplearner)
force-pushed
the
join_with
branch
from
May 1, 2022 16:57
f12457c to
2390598
Compare
This comment was marked as resolved.
This comment was marked as resolved.
Stephan T. Lavavej (StephanTLavavej)
approved these changes
Jun 14, 2022
This comment was marked as resolved.
This comment was marked as resolved.
Co-authored-by: Michael Schellenberger Costa <mschellenbergercosta@gmail.com>
Stephan T. Lavavej (StephanTLavavej)
approved these changes
Jun 15, 2022
Stephan T. Lavavej (StephanTLavavej)
approved these changes
Jun 17, 2022
Member
|
I've pushed a merge with |
Member
|
I'm speculatively mirroring this to the MSVC-internal repo. Further changes can be pushed, but please notify me. |
Casey Carter (CaseyCarter)
approved these changes
Jun 19, 2022
Michael Schellenberger Costa (miscco)
approved these changes
Jun 19, 2022
Stephan T. Lavavej (StephanTLavavej)
approved these changes
Jun 19, 2022
Member
|
Thanks for implementing this C++23 ranges feature! ✅ 😻 🎉 |
Igor Zhukov (fsb4000)
pushed a commit
to fsb4000/STL
that referenced
this pull request
Aug 13, 2022
Co-authored-by: Michael Schellenberger Costa <mschellenbergercosta@gmail.com> Co-authored-by: Stephan T. Lavavej <stl@nuwen.net> Co-authored-by: Casey Carter <Casey@Carter.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This implements P2441R2
views::join_with.Fixes #2538.
I need suggestions on test. This view depends on the category (input/forward/bidirectional), commonness, and element type of three ranges (outer, inner, pattern). Currently I simply copy the
instantiation_testfunction fromP0896R4_views_join, but it might be desirable to also test non-bidirectional_rangeor non-common_rangepatterns.