Skip to content

Implement LWG-3121: tuple constructor constraints for UTypes&&... overloads - #2640

Merged
Stephan T. Lavavej (StephanTLavavej) merged 9 commits into
microsoft:mainfrom
frederick-vs-ja:lwg-3121
Apr 16, 2022
Merged

Implement LWG-3121: tuple constructor constraints for UTypes&&... overloads#2640
Stephan T. Lavavej (StephanTLavavej) merged 9 commits into
microsoft:mainfrom
frederick-vs-ja:lwg-3121

Conversation

@frederick-vs-ja

Copy link
Copy Markdown
Contributor

Fixes #2390.

The original issue reported in LWG-3121 has been resolved. The addition part resolves LWG-3155.
@frederick-vs-ja
A. Jiang (frederick-vs-ja) requested a review from a team as a code owner April 5, 2022 13:37
@StephanTLavavej Stephan T. Lavavej (StephanTLavavej) added the LWG Library Working Group issue label Apr 5, 2022
Comment thread stl/inc/tuple Outdated
Co-authored-by: S. B. Tam <cpplearner@outlook.com>
Unbreak line.
Comment thread stl/inc/tuple Outdated
Comment thread tests/std/tests/LWG3121_constrained_tuple_forwarding_ctor/test.cpp
Comment thread tests/std/tests/LWG3121_constrained_tuple_forwarding_ctor/test.cpp Outdated
@StephanTLavavej

Copy link
Copy Markdown
Member

Thanks - and great test coverage! I went ahead and pushed very small changes for the style nitpicks I noticed.

@StephanTLavavej

Copy link
Copy Markdown
Member

I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed.

@StephanTLavavej
Stephan T. Lavavej (StephanTLavavej) merged commit 0c73091 into microsoft:main Apr 16, 2022
@StephanTLavavej

Copy link
Copy Markdown
Member

Thanks again for refining this complicated metaprogramming and getting the implementation one step closer to zero remaining LWG issues! 😸 🚀 🎉

@frederick-vs-ja
A. Jiang (frederick-vs-ja) deleted the lwg-3121 branch April 16, 2022 04:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

LWG Library Working Group issue

Projects

None yet

Development

Successfully merging this pull request may close these issues.

LWG-3121 tuple constructor constraints for UTypes&&... overloads

4 participants