<ranges>: Temporarily disable join_view for non-forward_ranges, pending resolution of LWG-3698 - #2727
Merged
Stephan T. Lavavej (StephanTLavavej) merged 4 commits intoMay 24, 2022
Conversation
Stephan T. Lavavej (StephanTLavavej)
approved these changes
May 18, 2022
Contributor
Author
|
FYI here's what I think the fix would roughly look like: https://github.com/cpplearner/STL/tree/lwg3698. |
Stephan T. Lavavej (StephanTLavavej)
approved these changes
May 18, 2022
Member
|
I'm speculatively mirroring this to the MSVC-internal repo - further changes can be pushed, but please notify me. |
Casey Carter (CaseyCarter)
approved these changes
May 22, 2022
Casey Carter (CaseyCarter)
left a comment
Contributor
There was a problem hiding this comment.
I'm applying a clarification to the error message to make the consequences of overriding clear.
Stephan T. Lavavej (StephanTLavavej)
approved these changes
May 22, 2022
timsong-cpp
reviewed
May 23, 2022
…oroughly. Co-authored-by: timsong-cpp <rs2740@gmail.com>
Stephan T. Lavavej (StephanTLavavej)
approved these changes
May 23, 2022
Member
|
Thanks for noticing this issue and preventing users from being bitten by it! 🐍 🦇 🧛 |
Igor Zhukov (fsb4000)
pushed a commit
to fsb4000/STL
that referenced
this pull request
Aug 13, 2022
… pending resolution of LWG-3698 (microsoft#2727) Co-authored-by: Casey Carter <cartec69@gmail.com> Co-authored-by: timsong-cpp <rs2740@gmail.com>
S. B. Tam (cpplearner)
added a commit
to cpplearner/STL
that referenced
this pull request
Feb 14, 2023
…range`s, pending resolution of LWG-3698 (microsoft#2727)" This reverts commit 2966813.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As pointed out in LWG-3698,
join_viewis currently broken for "stashing iterators" (iterators that return a reference to a member object). The issue mentions thatjoin_viewwould need to store the outer iterator in a non-propagating-cache for input ranges.The fix might change the layout of
join_view(and of its iterator type, if we don't want to store a redundant outer iterator). So I believe that it is useful to flag the affected uses ofjoin_view.This requires users to define a macro if they don't depend on the ABI of
join_viewand want to usejoin_viewfor input ranges. I hope it's not too much of a problem.