Improve filesystem file resizing - #2771
Merged
Stephan T. Lavavej (StephanTLavavej) merged 2 commits intoJul 1, 2022
Merged
Conversation
Alex Guteniev (AlexGuteniev)
approved these changes
Jun 9, 2022
AZero13 (AZero13)
force-pushed
the
FileSystem
branch
from
June 9, 2022 17:15
1fae77f to
338075c
Compare
Stephan T. Lavavej (StephanTLavavej)
approved these changes
Jun 10, 2022
AZero13 (AZero13)
force-pushed
the
FileSystem
branch
5 times, most recently
from
June 12, 2022 15:36
7c4d562 to
f29dd4c
Compare
Replace SetFilePointerEx with SetFileInformationByHandle
AZero13 (AZero13)
force-pushed
the
FileSystem
branch
from
June 12, 2022 18:10
b0a2624 to
0493319
Compare
Stephan T. Lavavej (StephanTLavavej)
approved these changes
Jun 13, 2022
nicole mazzuca (strega-nil-ms)
approved these changes
Jun 20, 2022
nicole mazzuca (strega-nil-ms)
left a comment
Contributor
There was a problem hiding this comment.
Nit, but otherwise approve
Stephan T. Lavavej (StephanTLavavej)
approved these changes
Jun 22, 2022
Member
|
As discussed in #2766, I've pushed changes to directly test these |
Member
|
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
Member
|
Thanks for reducing the number of OS calls in the filesystem implementation! 📁 🎉 😸 |
Igor Zhukov (fsb4000)
pushed a commit
to fsb4000/STL
that referenced
this pull request
Aug 13, 2022
Co-authored-by: Stephan T. Lavavej <stl@nuwen.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace SetFilePointerEx with SetFileInformationByHandle