Skip to content

fix hash_* visualizer issue #2784

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Stephan T. Lavavej (StephanTLavavej) merged 1 commit into from
Jun 25, 2022
Merged

fix hash_* visualizer issue #2784

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 15 additions & 4 deletions stl/debugger/STL.natvis
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1443,15 +1443,26 @@ SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
</Expand>
</Type>

<!-- VC 2015 - must have higher priority -->
<Type Name="stdext::hash_map&lt;*&gt;" Priority="Medium">
<AlternativeType Name="stdext::hash_multimap&lt;*&gt;" />
<AlternativeType Name="stdext::hash_set&lt;*&gt;" />
<AlternativeType Name="stdext::hash_multiset&lt;*&gt;" />
<DisplayString>{_List}</DisplayString>
<Expand>

@StephanTLavavej Stephan T. Lavavej (StephanTLavavej) Jun 13, 2022

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No change requested: In theory, comp could be a function pointer worth visualizing. However, it seems likely that it would have to be paired with an ADL-customized hash_value and that seems quite rare (given the poorly-documented nature of this non-Standard extension). I'm okay with this as-is.

<Item Name="[bucket_count]" IncludeView="detailed">_Maxidx</Item>
<Item Name="[load_factor]" IncludeView="detailed">((float)_List._Mypair._Myval2._Mysize) / ((float)_Maxidx)</Item>
<Item Name="[max_load_factor]" IncludeView="detailed">_Traitsobj._Max_buckets</Item>
<Item Name="[allocator]" ExcludeView="simple">_List._Mypair</Item>
<ExpandedItem>_List,view(simple)</ExpandedItem>
</Expand>
</Type>

<!-- VC 2015 - must have higher priority -->
<Type Name="std::unordered_map&lt;*&gt;" Priority="Medium">
<AlternativeType Name="std::unordered_multimap&lt;*&gt;" />
<AlternativeType Name="std::unordered_set&lt;*&gt;" />
<AlternativeType Name="std::unordered_multiset&lt;*&gt;" />
<AlternativeType Name="stdext::hash_map&lt;*&gt;" />
<AlternativeType Name="stdext::hash_multimap&lt;*&gt;" />
<AlternativeType Name="stdext::hash_set&lt;*&gt;" />
<AlternativeType Name="stdext::hash_multiset&lt;*&gt;" />
<DisplayString>{_List}</DisplayString>
<Expand>
<Item Name="[bucket_count]" IncludeView="detailed">_Maxidx</Item>
Expand Down