Skip to content

Implement LWG-3683: operator== for polymorphic_allocator cannot deduce template argument in common cases #2879

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Stephan T. Lavavej (StephanTLavavej) merged 3 commits into from
Jul 28, 2022
Merged

Implement LWG-3683: operator== for polymorphic_allocator cannot deduce template argument in common cases #2879

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ab39f0b
Add test cases for LWG-3683
frederick-vs-ja Jul 19, 2022
aa10ae4
Implement LWG-3683
frederick-vs-ja Jul 19, 2022
08c7c75
Merge branch 'microsoft:main' into lwg-3683
frederick-vs-ja Jul 24, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions stl/inc/xpolymorphic_allocator.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -282,6 +282,18 @@ namespace pmr {
return _Resource;
}

_NODISCARD_FRIEND bool operator==(
Comment thread
StephanTLavavej marked this conversation as resolved.
const polymorphic_allocator& _Lhs, const polymorphic_allocator& _Rhs) noexcept {
return *_Lhs._Resource == *_Rhs._Resource;
}

#if !_HAS_CXX20
_NODISCARD_FRIEND bool operator!=(
const polymorphic_allocator& _Lhs, const polymorphic_allocator& _Rhs) noexcept {
return *_Lhs._Resource != *_Rhs._Resource;
}
#endif // !_HAS_CXX20

private:
memory_resource* _Resource = _STD pmr::get_default_resource();
};
Expand Down
41 changes: 41 additions & 0 deletions tests/std/tests/P0220R1_polymorphic_memory_resources/test.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@
#include <cstdlib>
#include <deque>
#include <forward_list>
#include <functional>
#include <list>
#include <malloc.h>
#include <map>
Expand Down Expand Up @@ -946,6 +947,45 @@ namespace {
}
} // namespace eq

namespace eq_cvt {
void test() {
const auto pres = std::pmr::get_default_resource();
std::pmr::polymorphic_allocator<int> a = pres;
const auto ra = std::ref(a);
const auto cra = std::cref(a);

CHECK(a == pres);
CHECK(a == ra);
CHECK(a == cra);
CHECK(pres == a);
CHECK(pres == ra);
CHECK(pres == cra);
CHECK(ra == a);
CHECK(ra == pres);
CHECK(ra == ra);
CHECK(ra == cra);
CHECK(cra == a);
CHECK(cra == pres);
CHECK(cra == ra);
CHECK(cra == cra);

CHECK(!(a != pres));
CHECK(!(a != ra));
CHECK(!(a != cra));
CHECK(!(pres != a));
CHECK(!(pres != ra));
CHECK(!(pres != cra));
CHECK(!(ra != a));
CHECK(!(ra != pres));
CHECK(!(ra != ra));
CHECK(!(ra != cra));
CHECK(!(cra != a));
CHECK(!(cra != pres));
CHECK(!(cra != ra));
CHECK(!(cra != cra));
}
} // namespace eq_cvt

namespace destroy {
void test() {
bool destroyed = false;
Expand Down Expand Up @@ -1505,6 +1545,7 @@ int main() {
polymorphic_allocator::mem::select_on_container_copy_construction::test();
polymorphic_allocator::mem::resource::test();
polymorphic_allocator::eq::test();
polymorphic_allocator::eq_cvt::test();
polymorphic_allocator::destroy::test();

monotonic::ctor::buffer_upstream::test();
Expand Down