Skip to content

Implement LWG-3656: Inconsistent bit operations returning a count - #2880

Merged
Stephan T. Lavavej (StephanTLavavej) merged 8 commits into
microsoft:mainfrom
frederick-vs-ja:lwg-3656
Jul 28, 2022
Merged

Implement LWG-3656: Inconsistent bit operations returning a count#2880
Stephan T. Lavavej (StephanTLavavej) merged 8 commits into
microsoft:mainfrom
frederick-vs-ja:lwg-3656

Conversation

@frederick-vs-ja

@frederick-vs-ja A. Jiang (frederick-vs-ja) commented Jul 19, 2022

Copy link
Copy Markdown
Contributor

Towards #2872.

The libcxx test has been updated for LWG-3656 by LLVM-D120444. I'm a bit reluctant to skip that test...

@CaseyCarter Casey Carter (CaseyCarter) added LWG Library Working Group issue blocked Something is preventing work on this labels Jul 19, 2022
@frederick-vs-ja

This comment was marked as resolved.

@StephanTLavavej

This comment was marked as resolved.

@CaseyCarter Casey Carter (CaseyCarter) removed the blocked Something is preventing work on this label Jul 25, 2022
Comment thread tests/std/tests/P0556R3_bit_integral_power_of_two_operations/test.cpp Outdated
Comment thread stl/inc/bit
@StephanTLavavej

Copy link
Copy Markdown
Member

Thanks, this looks good! I searched for all occurrences of bit_width and found 3 more lines that should be updated, so I validated and pushed changes.

@StephanTLavavej

Copy link
Copy Markdown
Member

I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed.

@StephanTLavavej
Stephan T. Lavavej (StephanTLavavej) merged commit da41fe1 into microsoft:main Jul 28, 2022
@StephanTLavavej

Copy link
Copy Markdown
Member

Thanks for implementing so many LWG issue resolutions and improving conformance! 😻 😻

@frederick-vs-ja
A. Jiang (frederick-vs-ja) deleted the lwg-3656 branch July 28, 2022 03:11
Igor Zhukov (fsb4000) pushed a commit to fsb4000/STL that referenced this pull request Aug 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

LWG Library Working Group issue

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants