Implement P2499R0: string_view Range Constructor Should Be explicit - #2947
Merged
Stephan T. Lavavej (StephanTLavavej) merged 5 commits intoJul 28, 2022
Conversation
string_view Range Constructor Should Be explicit
Casey Carter (CaseyCarter)
suggested changes
Jul 26, 2022
Casey Carter (CaseyCarter)
left a comment
Contributor
There was a problem hiding this comment.
We need to add an entry for P2499R0 string_view Range Constructor Should Be explicit in the "[features] controlled by _HAS_CXX23" section of <yvals_core.h>" (Yes, this isn't much of a feature, but that's the process.) somewhere around line 317. (They're ordered by proposal number.)
This comment was marked as resolved.
This comment was marked as resolved.
Casey Carter (CaseyCarter)
approved these changes
Jul 26, 2022
Stephan T. Lavavej (StephanTLavavej)
approved these changes
Jul 26, 2022
Member
|
Perfect, thanks! |
Member
|
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
Member
|
Thanks for implementing this feature, following the original one you implemented! 😻 ✅ 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2935