Make filter_view::iterator unwrappable - #3000
Closed
nicole mazzuca (strega-nil) wants to merge 10 commits into
Closed
Make filter_view::iterator unwrappable#3000nicole mazzuca (strega-nil) wants to merge 10 commits into
filter_view::iterator unwrappable#3000nicole mazzuca (strega-nil) wants to merge 10 commits into
Conversation
additionally, add conditional noexcepts to a lot of `_Unwrapped()`s
plus, fix reverse_iterator up with an `_Unwrapped() &&`
This is an example of what we might do; it definitely requires discussion
filter_view::iterator unwrappable
nicole mazzuca (strega-nil)
marked this pull request as draft
August 6, 2022 17:44
| template <class _Iter> | ||
| using _Unwrapped_t = _Remove_cvref_t<decltype(_Get_unwrapped(_STD declval<_Iter>()))>; | ||
| template <class _Iter, bool _Is_unwrapped> | ||
| using _Maybe_unwrapped_t = conditional_t<_Is_unwrapped, _Unwrapped_t<_Iter>, _Remove_cvref_t<_Iter>>; |
Contributor
There was a problem hiding this comment.
Can we reuse _Maybe_wrapped?
Lines 60 to 61 in 3e046a4
still need unwrappable sentinel
Contributor
|
Closing for now; this requires a lot of underlying machinery to be defined, and we can do that work in algorithms. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an example of what we might do; it definitely requires discussion.
In theory, with more work, fixes #2997
Based on #2991