Skip to content

Update get_future's [[nodiscard("message")]] #3068

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Stephan T. Lavavej (StephanTLavavej) merged 4 commits into from
Sep 3, 2022
Merged

Update get_future's [[nodiscard("message")]] #3068

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5fe4108
new future message
AlexGuteniev Sep 1, 2022
a313040
Update stl/inc/yvals_core.h
AlexGuteniev Sep 1, 2022
f3a2606
formatting
AlexGuteniev Sep 1, 2022
8ae5c7a
as @CaseyCarter and @StephanTLavavej suggested
AlexGuteniev Sep 2, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions stl/inc/yvals_core.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -603,9 +603,8 @@
"the temporary 'std::future' is destroyed, waiting for an async result or evaluating " \
"a deferred result, thus defeating the purpose of 'std::async'.")

#define _NODISCARD_GET_FUTURE \
_NODISCARD_MSG("Getting the future more than once or not satisfying the obtained future will throw a " \
"future_error exception, so it is incorrect to call 'get_future' and discard the return value.")
#define _NODISCARD_GET_FUTURE \
_NODISCARD_MSG("Since 'get_future' may be called only once, discarding the result is likely a mistake.")

#pragma push_macro("msvc")
#pragma push_macro("known_semantics")
Expand Down