Skip to content

update working draft revision to N4917 - #3094

Merged
Stephan T. Lavavej (StephanTLavavej) merged 1 commit into
microsoft:mainfrom
fsb4000:patch-1
Sep 13, 2022
Merged

Stephan T. Lavavej (StephanTLavavej) merged 1 commit into
microsoft:mainfrom
fsb4000:patch-1

Conversation

@fsb4000

Copy link
Copy Markdown
Contributor

https://wg21.link/n4917 is not working currently but probably will be updated before this PR will be merged.

github release: https://github.com/cplusplus/draft/releases/download/n4917/n4917.pdf

@fsb4000
Igor Zhukov (fsb4000) requested a review from a team as a code owner September 8, 2022 17:19
@AlexGuteniev

Copy link
Copy Markdown
Contributor

The link works fine for me

@frederick-vs-ja

Copy link
Copy Markdown
Contributor

How about consistently updating the references to working drafts in comments/static_assert messages? I've updated the referenced number to N4910 in <xstring> and <cmath>, but not in other headers.

(It's weird that even change to README.md requires running tests...)

@StephanTLavavej Stephan T. Lavavej (StephanTLavavej) added the documentation Related to documentation or comments label Sep 8, 2022
@StephanTLavavej

Copy link
Copy Markdown
Member

A. Jiang (@frederick-vs-ja)

How about consistently updating the references to working drafts in comments/static_assert messages?

That's tracked by #182. It can't be automated (since we have to look out for paragraph numbers changing and wording being moved), but if you'd like to prepare a PR, go ahead! I'd say that it can be done incrementally (no need to update the entire codebase all at once; individual files already cite a mix of WP numbers so I don't even think intra-file consistency is necessary, although of course it's nice). I'd also say that the static_assert messages which are displayed to users are somewhat higher priority than code comments.

(It's weird that even change to README.md requires running tests...)

We need to run Code Format Validation to detect disallowed characters etc. It would be possible to configure Azure Pipelines to skip the build and test stages for readme changes - I see how to do it, but it would take some time, and README-only updates haven't been that frequent.

@fsb4000

Igor Zhukov (fsb4000) commented Sep 9, 2022

Copy link
Copy Markdown
Contributor Author

Yes, https://wg21.link/n4917 works for me via proxy but not directly.
Probably it's my ISP's problem, not that site's.

@StephanTLavavej

Copy link
Copy Markdown
Member

I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed.

@StephanTLavavej
Stephan T. Lavavej (StephanTLavavej) merged commit 6c0c9a9 into microsoft:main Sep 13, 2022
@StephanTLavavej

Copy link
Copy Markdown
Member

Thanks for updating the WP link! ⛓️ ✅ 😺

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Related to documentation or comments

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants