add <bit> with P0553R4 and P0556R3 (w/ rename from D1956) - #310
Merged
Stephan T. Lavavej (StephanTLavavej) merged 1 commit intoNov 19, 2019
Merged
Conversation
4 tasks
Contributor
"MSVC" ... "an" upcoming release
"This". Also, VSO-213718 is .NET bug: our internal bugs and PRs have separate namespaces, this links to a bug rather than a pull request. |
Casey Carter (CaseyCarter)
approved these changes
Nov 19, 2019
Casey Carter (CaseyCarter)
left a comment
Contributor
There was a problem hiding this comment.
The code is fine, but the commit message needs a bit of cleanup.
Charlie Barto (barcharcraz)
force-pushed
the
add_bit
branch
from
November 19, 2019 00:21
099a6ef to
7a02b31
Compare
Billy O'Neal (BillyONeal)
approved these changes
Nov 19, 2019
Stephan T. Lavavej (StephanTLavavej)
force-pushed
the
add_bit
branch
from
November 19, 2019 07:21
7a02b31 to
308f45a
Compare
Member
|
Congratulations! |
Daniel Marshall (SuperWig)
pushed a commit
to SuperWig/STL
that referenced
this pull request
Nov 21, 2019
Resolves microsoft#25 and resolves microsoft#26. Currently active for Clang and EDG, but not C1XX.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds header with implementation of P0553R4 and P0556R3 (w/ rename from D1956).
Currently it's only lit up on clang and EDG, however the implementation will work with MSVC
pending an upcoming release.
This mirrors Microsoft internal MSVC-PR-213718
Checklist
Be sure you've read README.md and understand the scope of this repo.
If you're unsure about a box, leave it unchecked. A maintainer will help you.
_Uglyas perhttps://eel.is/c++draft/lex.name#3.1 or there are no product code changes.
verified by an STL maintainer before automated testing is enabled on GitHub,
leave this unchecked for initial submission).
members, adding virtual functions, changing whether a type is an aggregate
or trivially copyable, etc.).
the C++ Working Draft (including any cited standards), other WG21 papers
(excluding reference implementations outside of proposed standard wording),
and LWG issues as reference material. If they were derived from a project
that's already listed in NOTICE.txt, that's fine, but please mention it.
If they were derived from any other project (including Boost and libc++,
which are not yet listed in NOTICE.txt), you must mention it here,
so we can determine whether the license is compatible and what else needs
to be done.