Restrict ADL for reference_wrapper and thread - #3101
Restrict ADL for reference_wrapper and thread#3101Stephan T. Lavavej (StephanTLavavej) merged 4 commits into
reference_wrapper and thread#3101Conversation
For `reference_wrapper` and `thread`. And update the references to the latest Working Draft as driven-by change.
|
Marking |
|
Removing |
Oh, I'm sorry for doing too much in one commit.😹 This PR does |
nicole mazzuca (strega-nil-ms)
left a comment
There was a problem hiding this comment.
This looks reasonable to me! Thanks!
|
Thanks - I've pushed small changes to fix citations, clarify a comment, and remove unnecessary parens. FYI nicole mazzuca (@strega-nil-ms) (as you previously approved) and Casey Carter (@CaseyCarter) (if you want to double-check the citation that you added in 2019). ✅ No modules impact. |
|
I'm not enthusiastic about section numbers in our working draft citations - they're just noise - but it's not worth the effort to pull them out at this point. |
I can go with removal of section numbers. Should we make an issue to track this? |
|
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
|
Thanks for investigating and fixing these libcxx test failures! 🚀 😻 📉 |
|
A. Jiang (@frederick-vs-ja) We already had #182, so I updated that issue to mention that section numbers should be dropped. |
This PR is unblocking two libcxx tests.
std/thread/thread.threads/thread.thread.class/thread.thread.constr/robust_against_adl.pass.cppstd/utilities/function.objects/refwrap/refwrap.invoke/robust_against_adl.pass.cppDriven-by changes:
path's comparison operators are IF-NDR #2358 is fixed, but the related libcxx test still fails because it requirespath's iterator to satisfybidirectional_iterator. The explanation should be changed.<type_traits>and<thread>are updated to WG21-N4917 with section numbers added.