Skip to content

Restrict ADL for reference_wrapper and thread - #3101

Merged
Stephan T. Lavavej (StephanTLavavej) merged 4 commits into
microsoft:mainfrom
frederick-vs-ja:small-adl-cleanup
Oct 12, 2022
Merged

Restrict ADL for reference_wrapper and thread#3101
Stephan T. Lavavej (StephanTLavavej) merged 4 commits into
microsoft:mainfrom
frederick-vs-ja:small-adl-cleanup

Conversation

@frederick-vs-ja

Copy link
Copy Markdown
Contributor

This PR is unblocking two libcxx tests.

  • std/thread/thread.threads/thread.thread.class/thread.thread.constr/robust_against_adl.pass.cpp
  • std/utilities/function.objects/refwrap/refwrap.invoke/robust_against_adl.pass.cpp

Driven-by changes:

  • <filesystem>: path's comparison operators are IF-NDR #2358 is fixed, but the related libcxx test still fails because it requires path's iterator to satisfy bidirectional_iterator. The explanation should be changed.
  • Referenced number to the Working Draft in <type_traits> and <thread> are updated to WG21-N4917 with section numbers added.
  • Other ADL-related failures get analyzed.

For `reference_wrapper` and `thread`. And update the references to the latest Working Draft as driven-by change.
@frederick-vs-ja
A. Jiang (frederick-vs-ja) requested a review from a team as a code owner September 14, 2022 08:26
@strega-nil-ms nicole mazzuca (strega-nil-ms) added the decision needed We need to choose something before working on this label Sep 14, 2022
@strega-nil-ms

Copy link
Copy Markdown
Contributor

Marking decision needed, as we need to discuss the underlying issue #140 this week at the STL maintainers' meeting.

@StephanTLavavej Stephan T. Lavavej (StephanTLavavej) added bug Something isn't working libcxx skip and removed decision needed We need to choose something before working on this libcxx skip labels Sep 21, 2022
@StephanTLavavej

Copy link
Copy Markdown
Member

Removing decision needed (as we've decided in #140), and this PR doesn't actually involve qualifying _Ugly names.

@frederick-vs-ja

Copy link
Copy Markdown
Contributor Author

Removing decision needed (as we've decided in #140), and this PR doesn't actually involve qualifying _Ugly names.

Oh, I'm sorry for doing too much in one commit.😹 This PR does _STD-qualify _Refwrap_ctor_fun (only this _Ugly name).

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks reasonable to me! Thanks!

Comment thread stl/inc/thread Outdated
Comment thread stl/inc/thread Outdated
Comment thread stl/inc/thread Outdated
Comment thread stl/inc/type_traits Outdated
Comment thread stl/inc/type_traits Outdated
@StephanTLavavej

Stephan T. Lavavej (StephanTLavavej) commented Sep 23, 2022

Copy link
Copy Markdown
Member

Thanks - I've pushed small changes to fix citations, clarify a comment, and remove unnecessary parens. FYI nicole mazzuca (@strega-nil-ms) (as you previously approved) and Casey Carter (@CaseyCarter) (if you want to double-check the citation that you added in 2019).

✅ No modules impact.

@CaseyCarter

Copy link
Copy Markdown
Contributor

I'm not enthusiastic about section numbers in our working draft citations - they're just noise - but it's not worth the effort to pull them out at this point.

@frederick-vs-ja

Copy link
Copy Markdown
Contributor Author

I'm not enthusiastic about section numbers in our working draft citations - they're just noise - but it's not worth the effort to pull them out at this point.

I can go with removal of section numbers. Should we make an issue to track this?

@StephanTLavavej

Copy link
Copy Markdown
Member

I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed.

@StephanTLavavej
Stephan T. Lavavej (StephanTLavavej) merged commit 6128830 into microsoft:main Oct 12, 2022
@StephanTLavavej

Copy link
Copy Markdown
Member

Thanks for investigating and fixing these libcxx test failures! 🚀 😻 📉

@StephanTLavavej

Copy link
Copy Markdown
Member

A. Jiang (@frederick-vs-ja) We already had #182, so I updated that issue to mention that section numbers should be dropped.

@frederick-vs-ja
A. Jiang (frederick-vs-ja) deleted the small-adl-cleanup branch October 12, 2022 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants