Skip to content

enable P0943R6_stdatomic_h test for clang - #3186

Merged
Stephan T. Lavavej (StephanTLavavej) merged 1 commit into
microsoft:mainfrom
fsb4000:fix2862
Nov 11, 2022
Merged

Stephan T. Lavavej (StephanTLavavej) merged 1 commit into
microsoft:mainfrom
fsb4000:fix2862

Conversation

@fsb4000

Copy link
Copy Markdown
Contributor

Fixes #2862

@fsb4000
Igor Zhukov (fsb4000) requested a review from a team as a code owner October 31, 2022 01:00

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks <3

@StephanTLavavej Stephan T. Lavavej (StephanTLavavej) added the test Related to test code label Oct 31, 2022
@StephanTLavavej

Copy link
Copy Markdown
Member

I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed.

@StephanTLavavej
Stephan T. Lavavej (StephanTLavavej) merged commit 0743f64 into microsoft:main Nov 11, 2022
@StephanTLavavej

Copy link
Copy Markdown
Member

Thanks for improving the test coverage here! 📈 🎉 😸

@fsb4000
Igor Zhukov (fsb4000) deleted the fix2862 branch November 12, 2022 01:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

test Related to test code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Clang 14's <stdatomic.h> is incompatible with MSVC's <stdatomic.h> ☢️

4 participants