Skip to content

Implement LWG-3646 std::ranges::view_interface::size returns a signed type #3261

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Stephan T. Lavavej (StephanTLavavej) merged 2 commits into from
Dec 6, 2022
Merged

Implement LWG-3646 std::ranges::view_interface::size returns a signed type #3261

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
79f9cae
Change of size types due to LWG-3646
frederick-vs-ja Dec 3, 2022
33f737d
Implement LWG-3646
frederick-vs-ja Dec 3, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions stl/inc/xutility
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3423,7 +3423,7 @@ namespace ranges {
#endif // TRANSITION, LLVM-44833
{
auto& _Self = _Cast();
return _RANGES end(_Self) - _RANGES begin(_Self);
return _STD _To_unsigned_like(_RANGES end(_Self) - _RANGES begin(_Self));
}

#ifdef __clang__ // TRANSITION, LLVM-44833
Expand All @@ -3437,7 +3437,7 @@ namespace ranges {
#endif // TRANSITION, LLVM-44833
{
auto& _Self = _Cast();
return _RANGES end(_Self) - _RANGES begin(_Self);
return _STD _To_unsigned_like(_RANGES end(_Self) - _RANGES begin(_Self));
}

#ifdef __clang__ // TRANSITION, LLVM-44833
Expand Down
9 changes: 4 additions & 5 deletions tests/std/tests/P0896R4_ranges_range_machinery/test.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1711,7 +1711,6 @@ namespace exhaustive_size_and_view_test {

using I = int*;
using CI = int const*;
using D = std::ptrdiff_t;
using S = std::size_t;
using UC = unsigned char;

Expand Down Expand Up @@ -1775,10 +1774,10 @@ namespace exhaustive_size_and_view_test {
STATIC_ASSERT(test<strange_view3 const, false, CI, S>());
STATIC_ASSERT(test<strange_view3 const&, false, CI, S>());

STATIC_ASSERT(test<strange_view4, true, I, D>());
STATIC_ASSERT(test<strange_view4&, false, I, D>());
STATIC_ASSERT(test<strange_view4 const, false, CI, D>());
STATIC_ASSERT(test<strange_view4 const&, false, CI, D>());
STATIC_ASSERT(test<strange_view4, true, I, S>());
STATIC_ASSERT(test<strange_view4&, false, I, S>());
STATIC_ASSERT(test<strange_view4 const, false, CI, S>());
STATIC_ASSERT(test<strange_view4 const&, false, CI, S>());

template <class = void>
constexpr bool strict_test_case() {
Expand Down