Implement LWG-3743 ranges::to's reserve may be ill-formed - #3269
Merged
Stephan T. Lavavej (StephanTLavavej) merged 8 commits intoDec 15, 2022
Merged
Conversation
Casey Carter (CaseyCarter)
approved these changes
Dec 6, 2022
Contributor
Author
// LWG example
auto r = std::ranges::subrange(std::views::iota(0ULL) | std::views::take(5), 5);
auto v = r | std::ranges::to<std::vector<std::size_t>>(0);The LWG example gives me a mixed signed/unsigned warning and I changed 0 to 0ULL without having a full understanding of where it is used and I only tested X86-64 |
Casey Carter (CaseyCarter)
self-requested a review
December 6, 2022 18:30
Casey Carter (CaseyCarter)
suggested changes
Dec 7, 2022
Co-authored-by: Casey Carter <cartec69@gmail.com>
nicole mazzuca (strega-nil-ms)
approved these changes
Dec 7, 2022
nicole mazzuca (strega-nil-ms)
left a comment
Contributor
There was a problem hiding this comment.
Thanks so much!
Contributor
|
Casey Carter (@CaseyCarter) changes have been pushed to add a TRANSITION comment and resolve your comments if you would like to re-review. |
Casey Carter (CaseyCarter)
approved these changes
Dec 7, 2022
Stephan T. Lavavej (StephanTLavavej)
approved these changes
Dec 7, 2022
Member
|
nicole mazzuca (@strega-nil-ms) Casey Carter (@CaseyCarter) I pushed a change to fix damaged bug number citations. |
Casey Carter (CaseyCarter)
approved these changes
Dec 9, 2022
Member
|
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
Member
|
Thanks for implementing this LWG issue resolution - well-formed code is so much nicer than ill-formed! 😹 🛠️ 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3224