Implement LWG-3737 take_view::sentinel should provide operator-

[A. Jiang (frederick-vs-ja)]

Fixes #3223.

(counted_iterator<counted_iterator<T>> seems a bit messy. Should I add a prettier test case?)

[Casey Carter (CaseyCarter)]

LGTM, just some style nits.

[nicole mazzuca (strega-nil-ms)]

LGTM, although the utility of this LWG issue seems suspect to me lol (given that it only triggers when disable_sized_range<R> && sized_sentinel_for<S, I>)

[Casey Carter (CaseyCarter)]

LGTM, although the utility of this LWG issue seems suspect to me lol (given that it only triggers when disable_sized_range<R> && sized_sentinel_for<S, I>)

More precisely, it's !sized_range<R> && sized_sentinel_for<sentinel_t<R>, iterator_t<R>>. Since ranges::size is smart enough to call begin and end an return the difference, this boils down to covering single-pass (not forward) ranges with sized_sentinel_for. IIRC I pointed this out to LWG and suggested closing as NAD, but LWG was convinced that it was worth doing "just in case" since the cost is a couple of small if constexpr branches.

[Stephan T. Lavavej (StephanTLavavej)]

Thanks! Really appreciate the test case, especially when it's non-trivial to set up like this one.

Casey Carter (@CaseyCarter) nicole mazzuca (@strega-nil-ms) I pushed changes after you approved, to defend against min macroization.

[Stephan T. Lavavej (StephanTLavavej)]

I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed.

[Stephan T. Lavavej (StephanTLavavej)]

Thanks for taking the STL to the next level of conformance! 📊 🎉 😹