Skip to content

Use if constexpr dispatch for _Pass_fn - #3389

Merged
Stephan T. Lavavej (StephanTLavavej) merged 2 commits into
microsoft:mainfrom
CaseyCarter:pass_fn
Feb 11, 2023
Merged

Use if constexpr dispatch for _Pass_fn#3389
Stephan T. Lavavej (StephanTLavavej) merged 2 commits into
microsoft:mainfrom
CaseyCarter:pass_fn

Conversation

@CaseyCarter

Copy link
Copy Markdown
Contributor

No description provided.

@CaseyCarter Casey Carter (CaseyCarter) added the throughput Must compile faster label Feb 5, 2023
@CaseyCarter
Casey Carter (CaseyCarter) requested a review from a team as a code owner February 5, 2023 05:28
Comment thread stl/inc/xutility Outdated
Comment thread stl/inc/xutility Outdated
Comment thread stl/inc/xutility
@StephanTLavavej

Copy link
Copy Markdown
Member

Thanks for removing the TRANSITION comment for VSO-386225 "[VSFeedback] C2 won't inline function pointers - Was: excessive Codegen on function_view" (linked to DevCom-16882). I kept seeing this when scanning TRANSITION comments but was never sure of the status of needing _Pass_fn.

@StephanTLavavej

Copy link
Copy Markdown
Member

I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed.

@StephanTLavavej
Stephan T. Lavavej (StephanTLavavej) merged commit 3218823 into microsoft:main Feb 11, 2023
@StephanTLavavej

Copy link
Copy Markdown
Member

Thanks for noticing and simplifying this widely used helper function! 😻 🎉 😸

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

throughput Must compile faster

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants