<atomic>: improve code documentation - #3406
Merged
Stephan T. Lavavej (StephanTLavavej) merged 1 commit intoMar 3, 2023
Merged
Conversation
* `_ATOMIC_LOAD_VERIFY_MEMORY_ORDER` is not a good name, as it is an optional memory barrier, not just a debug check * move "these macros are _not_ always safe" above all unsafe macros * preprocessor block comment as discussed in microsoft#351
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
Stephan T. Lavavej (StephanTLavavej)
approved these changes
Feb 28, 2023
Member
|
I think these are all improvements, thanks! |
Casey Carter (CaseyCarter)
approved these changes
Mar 1, 2023
Member
|
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
Member
☢️ ⚛️ 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
_ATOMIC_LOAD_VERIFY_MEMORY_ORDERis not a good name, as it is an optional memory barrier, not just a debug check