LWG-3850: views::as_const on empty_view<T> should return empty_view<const T> - #3423
Merged
Stephan T. Lavavej (StephanTLavavej) merged 4 commits intoFeb 14, 2023
Merged
Conversation
Jakub Mazurkiewicz (JMazurkiewicz)
requested a review
from a team
as a code owner
February 12, 2023 01:20
61 tasks
Casey Carter (CaseyCarter)
approved these changes
Feb 12, 2023
Stephan T. Lavavej (StephanTLavavej)
approved these changes
Feb 12, 2023
| const same_as<iterator_t<R>> auto i = r.begin(); | ||
| if (!is_empty) { | ||
| // (static analyzer doesn't realize that `i == nullptr` implies `is_empty`) | ||
| #pragma warning(suppress : 6011) // Dereferencing NULL pointer 'i' |
There was a problem hiding this comment.
No change requested: We avoid suppress in stl/inc (as it sometimes has issues with templates and/or modules, whereas push/disable/pop is reliable) but it's fine in stl/src and test code.
nicole mazzuca (strega-nil-ms)
approved these changes
Feb 13, 2023
nicole mazzuca (strega-nil-ms)
left a comment
Contributor
There was a problem hiding this comment.
I was concerned about empty_view<int&> being wrong, but it turns out that empty_view<reference-type> is invalid.
Member
|
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
Member
|
Thanks for helping the list of remaining LWG issues get closer to empty! 😹 📉 🎉 |
Jakub Mazurkiewicz (JMazurkiewicz)
added a commit
to JMazurkiewicz/STL
that referenced
this pull request
Feb 17, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3418.