<ranges>: Fix misused list-initializations - #3493
Merged
Stephan T. Lavavej (StephanTLavavej) merged 9 commits intoFeb 26, 2023
Merged
<ranges>: Fix misused list-initializations#3493Stephan T. Lavavej (StephanTLavavej) merged 9 commits into
<ranges>: Fix misused list-initializations#3493Stephan T. Lavavej (StephanTLavavej) merged 9 commits into
Conversation
Jakub Mazurkiewicz (JMazurkiewicz)
requested a review
from a team
as a code owner
February 22, 2023 15:21
nicole mazzuca (strega-nil-ms)
approved these changes
Feb 22, 2023
nicole mazzuca (strega-nil-ms)
left a comment
Contributor
There was a problem hiding this comment.
Thanks!
Stephan T. Lavavej (StephanTLavavej)
approved these changes
Feb 22, 2023
Member
|
Also thanks! I pushed a commit to delete 3 redundant lines, FYI nicole mazzuca (@strega-nil-ms). |
Member
|
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
Member
|
Thanks again for finding and fixing these occurrences of this bug! 🛠️ 🐞 ✨ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3014.
Library parts affected by this issue:
move_sentinel<S>(two constructors),transform_view<R, F>::_Iterator,join_view<R>::_Iterator,join_with_view<R, P>::_Iterator(two constructors),join_with_view<R, P>::_Sentinelelements_view<R, N>::_Iterator.