Use SRWLOCK_INIT to statically initialize stl_critical_section_win7::m_srw_lock - #3522
Merged
Stephan T. Lavavej (StephanTLavavej) merged 3 commits intoMar 7, 2023
Conversation
…n7::m_srw_lock. This doesn't affect the redist's interface - stl/src/primitives.hpp is built into the DLL or static LIB, so there's no mix-and-match concern. We use SRWLOCK_INIT everywhere now.
Stephan T. Lavavej (StephanTLavavej)
requested a review
from a team
as a code owner
March 3, 2023 19:04
Casey Carter (CaseyCarter)
approved these changes
Mar 4, 2023
Member
Author
|
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a minor (but strict) performance improvement as it avoids a Windows API call.
Although this changes separately compiled code, it doesn't affect the redist's interface, and we don't have to wait for the redist to be "unlocked".
stl/src/primitives.hppis built into the STL's DLLs and static LIBs, so there are no mix-and-match concerns with user code.We use
SRWLOCK_INITeverywhere else:STL/stl/src/atomic_wait.cpp
Line 65 in 16bb556
STL/stl/src/atomic_wait.cpp
Line 208 in 16bb556
STL/stl/src/atomic.cpp
Line 11 in 16bb556
STL/stl/src/stacktrace.cpp
Line 237 in 16bb556