Skip to content

Cleanups: Test code using ranges as an identifier, plus more - #3528

Merged
Stephan T. Lavavej (StephanTLavavej) merged 4 commits into
microsoft:mainfrom
StephanTLavavej:stl-cleanups-test-code
Mar 7, 2023
Merged

Cleanups: Test code using ranges as an identifier, plus more#3528
Stephan T. Lavavej (StephanTLavavej) merged 4 commits into
microsoft:mainfrom
StephanTLavavej:stl-cleanups-test-code

Conversation

@StephanTLavavej

Copy link
Copy Markdown
Member
  • P2321R2_views_zip was using ranges as an identifier. 🙀 Rename this to rngs, avoiding confusion.
  • Dev09_192736_tr1_prngs_not_copyconstructible, written a billion years ago, also had ranges. While this isn't really a problem, let's add a d suffix (also to the following weights), which is consistent with the preceding and following vector<float> rangesf and vector<long double> rangesl.
  • Dev09_056375_locale_cleanup, written a trillion years ago, could use some extremely minor cleanups:
    • Add preprocessor comments.
    • Drop a totally unnecessary using-directive.
      • In general, we should be wary of changing tests in ways that could disturb what they were testing, but there is no way that this had any effect, being scoped to main().
    • Change a C cast to reinterpret_cast.

@StephanTLavavej

Copy link
Copy Markdown
Member Author

I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed.

@StephanTLavavej
Stephan T. Lavavej (StephanTLavavej) merged commit a9768b4 into microsoft:main Mar 7, 2023
@StephanTLavavej
Stephan T. Lavavej (StephanTLavavej) deleted the stl-cleanups-test-code branch March 7, 2023 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ranges C++20/23 ranges test Related to test code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants