Cleanups: Avoid almost always auto - #3530
Merged
Stephan T. Lavavej (StephanTLavavej) merged 3 commits intoMar 7, 2023
Merged
Conversation
Name the parameters single_element_container and three_element_container, as that's relevant to the caller. Then we can rename the local copy to just `writable`, which avoids wrapping lines.
MSVC emits a probably-unjustified signed/unsigned warning if we attempt to directly initialize _Int_max. Since we're intentionally changing the type from int to size_t, it seems stylistically best to emphasize this with a static_cast anyways.
Stephan T. Lavavej (StephanTLavavej)
requested a review
from a team
as a code owner
March 3, 2023 20:34
nicole mazzuca (strega-nil-ms)
approved these changes
Mar 6, 2023
nicole mazzuca (strega-nil-ms)
left a comment
Contributor
There was a problem hiding this comment.
I still prefer almost always auto in a lot of these cases, but I know that's not the style of the standard library, so approve.
Member
Author
|
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
Stephan T. Lavavej (StephanTLavavej)
deleted the
stl-cleanups-almost-never-auto
branch
March 7, 2023 19:43
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We conventionally avoid the pattern
auto variable = Type{args};because it is strictly more complicated thanType variable{args};. Following this convention reservesautofor the cases where it's doing real work to deduce a type.We've accumulated a few cases which I'm cleaning up here. (There are a few more cases which I am reluctantly not changing, because
autoresults in code lining up nicely. I thought about it, though.)In
P2321R2_views_zip, I'm also performing some renames. We can name the parameterssingle_element_containerandthree_element_container, as that's relevant to the caller. Then we can rename the local copy to justwritable, which avoids wrapping lines.In
<__msvc_int128.hpp>, I'm usingstatic_cast. MSVC emits a signed/unsigned warning if we attempt to directly initialize_Int_max(possibly becausenumeric_limits::max()isconstexprbut notconsteval). Since we're intentionally changing the type frominttosize_t, it seems stylistically best to emphasize this with astatic_castanyways.