Skip to content

<ranges>: Fix ranges::equal for ranges with integer-class range_difference_t - #3551

Merged
Stephan T. Lavavej (StephanTLavavej) merged 3 commits into
microsoft:mainfrom
JMazurkiewicz:equal-gh3550
Mar 13, 2023
Merged

<ranges>: Fix ranges::equal for ranges with integer-class range_difference_t#3551
Stephan T. Lavavej (StephanTLavavej) merged 3 commits into
microsoft:mainfrom
JMazurkiewicz:equal-gh3550

Conversation

@JMazurkiewicz

Copy link
Copy Markdown
Contributor

Closes #3550.

@StephanTLavavej Stephan T. Lavavej (StephanTLavavej) added bug Something isn't working ranges C++20/23 ranges labels Mar 9, 2023
Comment thread tests/std/tests/P0896R4_ranges_alg_equal/test.cpp Outdated
@StephanTLavavej

Copy link
Copy Markdown
Member

I have massively reworked this PR by changing 16.7% of its lines 🤪 😹

Thanks for the fix!

@StephanTLavavej

Copy link
Copy Markdown
Member

I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed.

@StephanTLavavej

Copy link
Copy Markdown
Member

I pushed a commit to work around a notorious /clr bug affecting views::iota.

@StephanTLavavej
Stephan T. Lavavej (StephanTLavavej) merged commit 1e7d460 into microsoft:main Mar 13, 2023
@StephanTLavavej

Copy link
Copy Markdown
Member

Thanks for finding and fixing this ranges bug! 🐞 🛠️ 😸

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working ranges C++20/23 ranges

Projects

None yet

Development

Successfully merging this pull request may close these issues.

<ranges>: ranges::equal does not work for ranges with integer-class range_difference_t

3 participants