<mdspan>: Require concepts - #3560
Merged
Stephan T. Lavavej (StephanTLavavej) merged 1 commit intoMar 12, 2023
Merged
Conversation
Address some comments from my previous PR.
Jakub Mazurkiewicz (JMazurkiewicz)
requested a review
from a team
as a code owner
March 11, 2023 11:51
Daniel Marshall (SuperWig)
left a comment
Contributor
There was a problem hiding this comment.
(urgh GitHub app can't leave a single comment)
Stephan T. Lavavej (StephanTLavavej)
approved these changes
Mar 12, 2023
Stephan T. Lavavej (StephanTLavavej)
merged commit Mar 12, 2023
7901876
into
microsoft:feature/mdspan2
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes concepts mandatory for
<mdspan>.std::extentsclass,<mdspan>: Implement *Mandates* clauses #3535):extends->extents(obvious typo)static_assertmessages (<mdspan>: Implement *Mandates* clauses #3535 (comment)).I'm going to replace the rest of uses of SFINAE with concepts in follow-up PR.