<mdspan>: Add separate tests for extents and default_accessor - #3580
Merged
Stephan T. Lavavej (StephanTLavavej) merged 11 commits intoMar 17, 2023
Merged
Conversation
Jakub Mazurkiewicz (JMazurkiewicz)
requested a review
from a team
as a code owner
March 17, 2023 16:49
Stephan T. Lavavej (StephanTLavavej)
requested changes
Mar 17, 2023
Stephan T. Lavavej (StephanTLavavej)
approved these changes
Mar 17, 2023
Stephan T. Lavavej (StephanTLavavej)
merged commit Mar 17, 2023
404605b
into
microsoft:feature/mdspan2
Member
|
Thanks for extending this test coverage! 😹 |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Short motivation:
That said, this PR adds:
extentsanddefault_accessor(I'll introduce the rest of the tests in other PR),<type_traits>include in<mdspan>(see<mdspan>: Use concepts everywhere and addmdspandeduction guides #3564 (comment)).P0009R18_mdspan_extents/test.cpptests have twoFIXMEcomment, as there might be a bug inextentsimplementation