Fix silent bad codegen for vectorized meow_element() above 4 GB - #3619
Merged
Stephan T. Lavavej (StephanTLavavej) merged 6 commits intoApr 7, 2023
Merged
Stephan T. Lavavej (StephanTLavavej) merged 6 commits into
Stephan T. Lavavej (StephanTLavavej) merged 6 commits into
Conversation
Stephan T. Lavavej (StephanTLavavej)
requested a review
from a team
as a code owner
April 3, 2023 21:42
Co-authored-by: Alex Guteniev <gutenev@gmail.com>
This reverts commit 3589b28.
Member
Author
|
I'm speculatively mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
nicole mazzuca (strega-nil-ms)
approved these changes
Apr 7, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3617.
static_cast<size_t>._Base + _V_pos * 16 + _H_pos, where_Basewasconst char *,_V_poswasunsigned int, and_H_poswasunsigned long.test_various_containersas we disable instructions.test_min_max_element_support.hpp.GH_003617_vectorized_meow_element.fast_matrix.lst(one configuration, optimized) because it takes a while and consumes a ton of memory if the usual matrix is used. (I originally tried to fuse it intoVSO_0000000_vector_algorithmsbut that was infeasible.)