Skip to content

Move _Char_traits_eq and _Char_traits_lt from <xstring> to <regex> - #3625

Merged
Stephan T. Lavavej (StephanTLavavej) merged 1 commit into
microsoft:mainfrom
frederick-vs-ja:throughput-regex-xstring
Apr 7, 2023
Merged

Move _Char_traits_eq and _Char_traits_lt from <xstring> to <regex>#3625
Stephan T. Lavavej (StephanTLavavej) merged 1 commit into
microsoft:mainfrom
frederick-vs-ja:throughput-regex-xstring

Conversation

@frederick-vs-ja

Copy link
Copy Markdown
Contributor

As these functors are only used in <regex>. Separated from #3623.

@frederick-vs-ja
A. Jiang (frederick-vs-ja) requested a review from a team as a code owner April 5, 2023 06:49
@StephanTLavavej

Copy link
Copy Markdown
Member

Thanks, this is an excellent change!

  • Pure code movement, no other changes.
  • The partial specializations are unquestionably safe - while they aren't next to the primary templates, they appear immediately after the _Char_traits_meow types they're being specialized for, so there is zero chance that the primary templates could have been used before the partial specializations are seen.
  • These are internal types, so there is no breaking change impact unless users were being very bad kitties indeed 😼

@barcharcraz

Copy link
Copy Markdown
Contributor

Verified identical code (only movement). Looks good.

@StephanTLavavej

Copy link
Copy Markdown
Member

I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed.

@StephanTLavavej
Stephan T. Lavavej (StephanTLavavej) merged commit 2df667e into microsoft:main Apr 7, 2023
@StephanTLavavej

Copy link
Copy Markdown
Member

Thanks again for this small but clean throughput improvement! 🐈 🚀 🎉

@frederick-vs-ja
A. Jiang (frederick-vs-ja) deleted the throughput-regex-xstring branch April 8, 2023 05:18
@StephanTLavavej Stephan T. Lavavej (StephanTLavavej) added the regex meow is a substring of homeowner label Jun 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

regex meow is a substring of homeowner throughput Must compile faster

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants