Skip to content

<mdspan>: Cleanup for _CONSTEVAL #3638

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Stephan T. Lavavej (StephanTLavavej) merged 2 commits into from
May 24, 2023
Merged

<mdspan>: Cleanup for _CONSTEVAL #3638

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
55624c8
`<mdspan>`: Cleanup for `_CONSTEVAL`
frederick-vs-ja Apr 8, 2023
2f3ae46
Merge remote-tracking branch 'origin/feature/mdspan2' into mdspan-con…
frederick-vs-ja May 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions stl/inc/mdspan
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ public:
private:
static constexpr array<rank_type, _Rank> _Static_extents = {_Extents...};

_NODISCARD static _CONSTEVAL auto _Make_dynamic_indices() noexcept {
_NODISCARD static consteval auto _Make_dynamic_indices() noexcept {
array<rank_type, _Rank + 1> _Result{};
rank_type _Counter = 0;
for (rank_type _Idx = 0; _Idx < _Rank; ++_Idx) {
Expand All @@ -59,7 +59,7 @@ private:

static constexpr array<rank_type, _Rank + 1> _Dynamic_indices = _Make_dynamic_indices();

_NODISCARD static _CONSTEVAL auto _Make_dynamic_indices_inv() noexcept {
_NODISCARD static consteval auto _Make_dynamic_indices_inv() noexcept {
array<rank_type, _Rank> _Result{};
for (rank_type _Idx = 0; _Idx < _Rank; ++_Idx) {
for (rank_type _Idx_inv = 0; _Idx_inv < _Rank; ++_Idx_inv) {
Expand Down Expand Up @@ -249,7 +249,7 @@ public:
return _Result;
}

_NODISCARD static _CONSTEVAL bool _Is_index_space_size_representable() {
_NODISCARD static consteval bool _Is_index_space_size_representable() {
if constexpr (rank_dynamic() == 0 && rank() > 0) {
return _STD in_range<index_type>((_Extents * ...));
} else {
Expand Down