Expand std::iter_swap and remove _Swap_adl - #3700
Merged
Casey Carter (CaseyCarter) merged 6 commits intoMay 18, 2023
Merged
Conversation
Also - Move `std::iter_swap` from `<utility>` to `<algorithm>`. - In `_Partition_by_median_guess_unchecked`, only evaluate `_Prev_iter(_Glast)` once.
std::iter_swap and remove _Swap_adlstd::iter_swap
std::iter_swapstd::iter_swap and _Swap_adl in free functions
std::iter_swap and _Swap_adl in free functionsstd::iter_swap and remove _Swap_adl
Stephan T. Lavavej (StephanTLavavej)
approved these changes
May 15, 2023
Member
|
Thanks, this is a nice improvement for debuggability! I pushed a commit to remove a couple of using-declarations. |
Member
|
I'm speculatively mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
nicole mazzuca (strega-nil-ms)
approved these changes
May 17, 2023
Contributor
|
Thanks for swapping calls to |
Jakub Mazurkiewicz (JMazurkiewicz)
added a commit
to JMazurkiewicz/STL
that referenced
this pull request
May 30, 2023
Jakub Mazurkiewicz (JMazurkiewicz)
added a commit
to JMazurkiewicz/STL
that referenced
this pull request
Jun 6, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also
std::iter_swapfrom<utility>to<algorithm>._Partition_by_median_guess_unchecked, only evaluate_Prev_iter(_Glast)once.Edit: I attempted to remove
_Swap_adldirectly but this failed due toT::swapmember functions.Edit: I should write
using _STD swap;.Fixes #2692.
In WG21-N4140 and WG21-N4659, the
std::swapoverload for arrays relied onstd::swap_ranges(N4140 [utility.swap]/6, N4659 [utility.swap]/6), whilestd::swap_rangesrecursively relied onstd::swap(N4140 [alg.swap]/2, N4659 [alg.swap]/2). So I believe even if old standards allowed specializingstd::iter_swapwith making its behavior different (which is not a fact IMO),std::swapshouldn't be affected.std::iter_swapis only specified to be used forstd::reverse(N4140 [alg.reverse]/2, N4659 [alg.reverse]/2, N4868 [alg.reverse]/2). As said in #2692 (comment), I think it should be OK to inlinestd::iter_swapinstd::reverseeven in old modes.