<mdspan>: Add new debug checks to layout mappings - #3702
Merged
Stephan T. Lavavej (StephanTLavavej) merged 2 commits intoMay 15, 2023
Merged
Conversation
Jakub Mazurkiewicz (JMazurkiewicz)
requested a review
from a team
as a code owner
May 14, 2023 21:23
Stephan T. Lavavej (StephanTLavavej)
approved these changes
May 15, 2023
| } | ||
|
|
||
| void test_call_operator() { | ||
| layout_stride::mapping<extents<unsigned, 5, 3, 4>> m; |
There was a problem hiding this comment.
Nitpick for followup: We conventionally say unsigned int instead of unsigned.
Stephan T. Lavavej (StephanTLavavej)
merged commit May 15, 2023
67b9723
into
microsoft:feature/mdspan2
Member
|
Thanks, looks great! 😻 I had a couple of nitpicks for followup but they weren't worth resetting testing here, they can be addressed later. |
Jakub Mazurkiewicz (JMazurkiewicz)
added a commit
to JMazurkiewicz/STL
that referenced
this pull request
May 16, 2023
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
<mdspan>: Completely reworkstd::extents#3586 (comment)),P0009R18_mdspan_layout_left/test.cpp,<mdspan>: Remove some C28020 warning suppressions #3690 I've missed one warning, reduce it here.