Workaround for non-_Ugly attribute tokens - #3760
Merged
Stephan T. Lavavej (StephanTLavavej) merged 4 commits intoJun 15, 2023
Merged
Stephan T. Lavavej (StephanTLavavej) merged 4 commits into
Stephan T. Lavavej (StephanTLavavej) merged 4 commits into
Conversation
And fix copy pasta
Stephan T. Lavavej (StephanTLavavej)
approved these changes
Jun 12, 2023
nicole mazzuca (strega-nil-ms)
approved these changes
Jun 14, 2023
Member
|
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
Member
|
Thanks for improving our macroization defenses! 🛡️ 🎉 ✨ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is trying to push and pop these attribute tokens like
new. Considering[[msvc::lifetimebound]]which is about to be used (#3754).Fixes #2645.