Skip to content

<condition_variable>: Fixes bad timeout in wait_until with unsigned rep - #3761

Merged
Stephan T. Lavavej (StephanTLavavej) merged 3 commits into
microsoft:mainfrom
MattStephanson:gh3756-cond-block
Jun 15, 2023
Merged

<condition_variable>: Fixes bad timeout in wait_until with unsigned rep#3761
Stephan T. Lavavej (StephanTLavavej) merged 3 commits into
microsoft:mainfrom
MattStephanson:gh3756-cond-block

Conversation

@MattStephanson

Copy link
Copy Markdown
Contributor

Fixes #3756.

@MattStephanson

This comment was marked as resolved.

Comment thread stl/inc/condition_variable Outdated
@StephanTLavavej Stephan T. Lavavej (StephanTLavavej) added the bug Something isn't working label Jun 11, 2023
@StephanTLavavej

Copy link
Copy Markdown
Member

Thanks, I think that this is a minimal, safe fix.

Comment thread stl/inc/condition_variable Outdated
@MattStephanson

This comment was marked as resolved.

@StephanTLavavej

Copy link
Copy Markdown
Member

I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed.

@StephanTLavavej
Stephan T. Lavavej (StephanTLavavej) merged commit c3c76a8 into microsoft:main Jun 15, 2023
@StephanTLavavej

Copy link
Copy Markdown
Member

Thanks for fixing this long-standing bug - it's about time! 😹 ⏳ 🎉

@MattStephanson
Matt Stephanson (MattStephanson) deleted the gh3756-cond-block branch February 27, 2026 06:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

<condition_variable>: condition_variable_any::wait_until may cause infinite wait

5 participants