-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Fix fstream.seekp(0, ios::cur)
#3773
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Stephan T. Lavavej (StephanTLavavej)
merged 22 commits into
microsoft:main
from
achabense:_For_fstream
Jun 22, 2023
Merged
Changes from all commits
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
f328e63
remove `_Off != 0 || _Way != ios_base::cur`
achabense 273f8ce
formatting
achabense aefc30a
Create test.cpp
achabense 00d6691
Create env.lst
achabense 2066810
Update test.lst
achabense d347f17
Merge pull request #1 from achabense/_For_fstream_addcheck
achabense 02668ef
formatting
achabense d6db4f7
formatting
achabense bffd1f3
formatting
achabense 373cb4d
Delete env.lst
achabense 92c3546
Delete test.cpp
achabense 0d7890b
Create env.lst
achabense 3aa878c
Add files via upload
achabense a17f51c
.
achabense dd89223
..
achabense a068e86
.
achabense bdc64a4
.
achabense 5b379da
Delete env.lst
achabense 76966ed
Add files via upload
achabense 2aa3d11
Update env.lst
achabense d9a8fdf
Code review feedback.
StephanTLavavej 5eb4294
Avoid string_view so the test is C++14
CaseyCarter File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| # Copyright (c) Microsoft Corporation. | ||
| # SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception | ||
|
|
||
| RUNALL_INCLUDE ..\usual_matrix.lst |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,47 @@ | ||
| // Copyright (c) Microsoft Corporation. | ||
| // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception | ||
|
|
||
| #include <cassert> | ||
| #include <cstring> | ||
| #include <fstream> | ||
| #include <ios> | ||
|
|
||
| int main() { | ||
| using namespace std; | ||
|
|
||
| fstream f("test.txt", ios::in | ios::out | ios::trunc); | ||
|
|
||
| f << "123"; | ||
|
|
||
| auto check = [&f](const char(&content)[4]) { | ||
| char buffer[4]{}; | ||
| f.seekg(0); | ||
| f.read(buffer, 3); | ||
| assert(f); | ||
| assert(memcmp(buffer, content, 4) == 0); | ||
| }; | ||
|
|
||
| f.seekg(0); | ||
| (void) f.get(); | ||
| f.seekp(f.tellp()); | ||
| f << "*"; | ||
| check("1*3"); | ||
|
|
||
| f.seekg(0); | ||
| (void) f.get(); | ||
| f.seekp(0, ios::cur); | ||
| f << "!"; | ||
| check("1!3"); | ||
|
|
||
| f.seekg(0); | ||
| (void) f.get(); | ||
| f.seekp(1, ios::cur); | ||
| f << "!"; | ||
| check("1!!"); | ||
|
|
||
| f.seekg(0); | ||
| (void) f.get(); | ||
| f.seekp(-1, ios::cur); | ||
| f << "!"; | ||
| check("!!!"); | ||
| } | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.