<mdspan>: Make extents truly empty when rank_dynamic() == 0 - #3825
Merged
Stephan T. Lavavej (StephanTLavavej) merged 4 commits intoJul 3, 2023
Merged
Conversation
Jakub Mazurkiewicz (JMazurkiewicz)
requested a review
from a team
as a code owner
June 23, 2023 13:51
* Introduce `_Calculate_rank_dynamic` template variable for easier `rank_dynamic()` computations, * Introduce `_Dynamic_extents_array` - a base class for `std::extents`, * Remove `extents::_Static_extents_only` and `extents::_Dynamic_extents`, * Add tests.
Jakub Mazurkiewicz (JMazurkiewicz)
force-pushed
the
mdspan/ebo-extents
branch
from
June 23, 2023 15:01
c87fbc5 to
b41de37
Compare
Stephan T. Lavavej (StephanTLavavej)
approved these changes
Jul 3, 2023
Stephan T. Lavavej (StephanTLavavej)
merged commit Jul 3, 2023
2a12d44
into
microsoft:feature/mdspan2
Member
|
Awesome, thank you! I had one suggestion for followup. 😻 🎉 |
Jakub Mazurkiewicz (JMazurkiewicz)
added a commit
to JMazurkiewicz/STL
that referenced
this pull request
Jul 4, 2023
Jakub Mazurkiewicz (JMazurkiewicz)
added a commit
to JMazurkiewicz/STL
that referenced
this pull request
Jul 5, 2023
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
_Calculate_rank_dynamictemplate variable for easierrank_dynamic()computations,_Maybe_empty_array- a base class forstd::extentsand (in the future) forstd::layout_stride::mapping,extents::_Static_extents_onlyandextents::_Dynamic_extents,