Final `mdspan` test fixes - #3954

Merged

Stephan T. Lavavej (StephanTLavavej) merged 13 commits into

microsoft:feature/mdspan2from

StephanTLavavej:final-mdspan-test-fixes

Aug 12, 2023

Commits on Aug 12, 2023

Include `<utility>` for `make_index_sequence`.
Stephan T. Lavavej (StephanTLavavej)
committed
3fe0769
Use `bool` underlying types when we call `to_underlying()` later.
Stephan T. Lavavej (StephanTLavavej)
committed
1a76770
`Mdspan` => `mdspan` in comments.
Stephan T. Lavavej (StephanTLavavej)
committed
c96d4fe
Rename an `array` from `s` to `a`.
Stephan T. Lavavej (StephanTLavavej)
committed
107f9cb
Mark `ActionTracker` observers as `[[nodiscard]]`.
Stephan T. Lavavej (StephanTLavavej)
committed
96070d8
Use `M1` typedef. Rename `m2` => `m1` to avoid looking weird.
Stephan T. Lavavej (StephanTLavavej)
committed
475f751
Extract `Mapping` typedef, like the block immediately above, and the `layout_right` test.
Stephan T. Lavavej (StephanTLavavej)
committed
cd144eb
`LyingLayout` inherits from `layout_left::mapping<Extents>`; use that for `is_always_exhaustive()`.
Stephan T. Lavavej (StephanTLavavej)
committed
a102f21
Drop repeated line; `span<int>` is inherently symmetry-breaking here.
Stephan T. Lavavej (StephanTLavavej)
committed
e0531a2
Construct `layout_stride::mapping` without an extra `span`, matching `P0009R18_mdspan_layout_right`.
Stephan T. Lavavej (StephanTLavavej)
committed
c381fd4
In `P0009R18_mdspan_layout_right`, `check_construction_from_other_right_mapping()` was missing "Check effects", while `check_construction_from_other_left_mapping()` was testing `layout_right::mappi…
Stephan T. Lavavej (StephanTLavavej)
committed
67b39e9
Test how comparisons are guaranteed to be `noexcept`.
Stephan T. Lavavej (StephanTLavavej)
committed
53d90f5
Fix tangled tests in P0009R18_mdspan_extents_death.
Stephan T. Lavavej (StephanTLavavej)
committed
c164211

Navigation Menu

Uh oh!

Final `mdspan` test fixes - #3954

Final `mdspan` test fixes#3954
Stephan T. Lavavej (StephanTLavavej) merged 13 commits into
microsoft:feature/mdspan2from
StephanTLavavej:final-mdspan-test-fixes

Commits on Aug 12, 2023

Include `<utility>` for `make_index_sequence`.

Use `bool` underlying types when we call `to_underlying()` later.

`Mdspan` => `mdspan` in comments.

Rename an `array` from `s` to `a`.

Mark `ActionTracker` observers as `[[nodiscard]]`.

Use `M1` typedef. Rename `m2` => `m1` to avoid looking weird.

Extract `Mapping` typedef, like the block immediately above, and the `layout_right` test.

`LyingLayout` inherits from `layout_left::mapping<Extents>`; use that for `is_always_exhaustive()`.

Drop repeated line; `span<int>` is inherently symmetry-breaking here.

Construct `layout_stride::mapping` without an extra `span`, matching `P0009R18_mdspan_layout_right`.

In `P0009R18_mdspan_layout_right`, `check_construction_from_other_right_mapping()` was missing "Check effects", while `check_construction_from_other_left_mapping()` was testing `layout_right::mappi…

Test how comparisons are guaranteed to be `noexcept`.

Fix tangled tests in P0009R18_mdspan_extents_death.