`<mdspan>`: Product code review - #3971

Merged

Stephan T. Lavavej (StephanTLavavej) merged 12 commits into

microsoft:feature/mdspan2from

StephanTLavavej:final-mdspan

Aug 15, 2023

Commits on Aug 15, 2023

Unconditionally strengthen `mdspan::is_always_MEOW()`.
Stephan T. Lavavej (StephanTLavavej)
committed
99fabc9
Drop strengthened comment; `_Access_impl()` is `_Ugly`
Stephan T. Lavavej (StephanTLavavej)
committed
2f40cf7
Follow N4950 \[mdspan.mdspan.cons\]/8.1 by saying `const _OtherIndexType&` in this constraint.
Stephan T. Lavavej (StephanTLavavej)
committed
5529f16
In `default_accessor`, define `access()` before `offset()` to follow the order of N4950 \[mdspan.accessor.default.overview\].
Stephan T. Lavavej (StephanTLavavej)
committed
364622e
`layout_stride::template mapping` is unnecessary; `layout_stride` is not a template.
Stephan T. Lavavej (StephanTLavavej)
committed
49d335e
Add `explicit` to the deduction guide `extents(_Integrals...)`, depicted by N4950 \[mdspan.extents.overview\] and \[mdspan.extents.cons\]/12.
Stephan T. Lavavej (StephanTLavavej)
committed
4ce75ee
Style: Reorder the template parameters for `_Contains_multidimensional_index()` to match its function parameters; it's always called with template argument deduction.
Stephan T. Lavavej (StephanTLavavej)
committed
b328d13
Step 1: Move `_Multidimensional_access()` up.
Stephan T. Lavavej (StephanTLavavej)
committed
7214197
Step 2: Add conditional `noexcept` to `_Multidimensional_access()`, not commented as strengthened because it's `_Ugly`.
Stephan T. Lavavej (StephanTLavavej)
committed
41c438f
Step 3: Add `as_const()` to the `array` overload, so it exactly matches the `span` overload.
Stephan T. Lavavej (StephanTLavavej)
committed
ef8c8c2
Step 4: Replace lambdas with `_Multidimensional_subscript()`.
Stephan T. Lavavej (StephanTLavavej)
committed
c193bce
Step 5: Add conditional `noexcept` to `_Multidimensional_subscript` (not commented, it's `_Ugly`), then strengthen `operator[]` for `span`/`array`.
Stephan T. Lavavej (StephanTLavavej)
committed
1c92a8e