Skip to content

Update _MSVC_STL_UPDATE to September 2023 - #4003

Merged
Stephan T. Lavavej (StephanTLavavej) merged 1 commit into
microsoft:mainfrom
kissholic:main
Sep 7, 2023
Merged

Update _MSVC_STL_UPDATE to September 2023#4003
Stephan T. Lavavej (StephanTLavavej) merged 1 commit into
microsoft:mainfrom
kissholic:main

Conversation

@kissholic

@kissholic kissholic commented Sep 1, 2023

Copy link
Copy Markdown
Contributor

Fixes #4001

@kissholic
kissholic requested a review from a team as a code owner September 1, 2023 02:28
@fsb4000

Copy link
Copy Markdown
Contributor

Edit your first post to Fixes #4001

@celonymire Sam Huang (celonymire) left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BTW, the title of the PR is probably meant to say "September" :)

@CaseyCarter Casey Carter (CaseyCarter) changed the title Update _MSVC_STL_UPDATE to August 2023 Update _MSVC_STL_UPDATE to September 2023 Sep 1, 2023
@CaseyCarter Casey Carter (CaseyCarter) added the enhancement Something can be improved label Sep 1, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change is good. I've changed "August" to "September" in the title, and added "Fixes #4001" to the description so the issue is linked to the PR (and will be automagically closed when the PR merges). Thanks!

@StephanTLavavej

Copy link
Copy Markdown
Member

I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed.

@StephanTLavavej
Stephan T. Lavavej (StephanTLavavej) merged commit d97e997 into microsoft:main Sep 7, 2023
@StephanTLavavej

Copy link
Copy Markdown
Member

Thanks for updating this version macro and congratulations on your first microsoft/STL commit! 🎉 😸 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement Something can be improved

Projects

None yet

Development

Successfully merging this pull request may close these issues.

<yvals_core.h>: Update _MSVC_STL_UPDATE to September 2023

5 participants