Skip to content

Prepare for impending LLVM 17 release - #4014

Merged
Stephan T. Lavavej (StephanTLavavej) merged 8 commits into
microsoft:mainfrom
CaseyCarter:llvm17
Sep 14, 2023
Merged

Prepare for impending LLVM 17 release#4014
Stephan T. Lavavej (StephanTLavavej) merged 8 commits into
microsoft:mainfrom
CaseyCarter:llvm17

Conversation

@CaseyCarter

@CaseyCarterCasey Carter (CaseyCarter) commented Sep 7, 2023•
edited
Loading

Copy link
Copy Markdown
Contributor

I tested with LLVM 17.0.0-rc4 and found a couple of issues / regressions:

  • Instead of fixing the friend declaration issues as we expected, they get worse in Clang 17. I relabeled the workaround in <ranges> with LLVM-61763 and added another similar workaround for zip_transform_view.
  • Clang seems to be confused by the deduced return type of our implementation of forward_like (LLVM-64029)

@CaseyCarterCasey Carter (CaseyCarter) added the enhancement Something can be improved label Sep 7, 2023
@CaseyCarter
Casey Carter (CaseyCarter) marked this pull request as ready for review September 7, 2023 18:47
StephanTLavavej
Stephan T. Lavavej (StephanTLavavej) requested changes Sep 7, 2023
View reviewed changes
Comment threadstl/inc/utility Outdated
Comment threadstl/inc/utility Outdated
CaseyCarter
Casey Carter (CaseyCarter) commented Sep 7, 2023
View reviewed changes
Comment threadstl/inc/utility Outdated
@CaseyCarter
perma-workaround LLVM-60429
9a3260e
* Move `_Maybe_const` up from `<ranges>` into `<type_traits>`
* Use `is_rvalue_reference_v<T&&>` instead of `is_lvalue_reference_v<T>`. I'm certain they are complements - so it doesn't matter for correctness - but the former more closely matches the Standard wording which makes things easier for code readers.
frederick-vs-ja
A. Jiang (frederick-vs-ja) reviewed Sep 8, 2023
View reviewed changes
Comment threadstl/inc/utility
StephanTLavavej
Stephan T. Lavavej (StephanTLavavej) requested changes Sep 8, 2023
View reviewed changes
Comment threadstl/inc/ranges
frederick-vs-ja
A. Jiang (frederick-vs-ja) reviewed Sep 8, 2023
View reviewed changes
Comment threadstl/inc/utility Outdated
@CaseyCarter

This comment was marked as outdated.

Sign in to view
@azure-pipelines

This comment was marked as outdated.

Sign in to view
@CaseyCarter

This comment was marked as resolved.

Sign in to view
@azure-pipelines

This comment was marked as resolved.

Sign in to view
strega-nil-ms
nicole mazzuca (strega-nil-ms) approved these changes Sep 8, 2023
View reviewed changes

@strega-nil-msnicole mazzuca (strega-nil-ms) left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I prefer the updated forward_like anyways.

@StephanTLavavej

Stephan T. Lavavej (StephanTLavavej) commented Sep 13, 2023

Copy link
Copy Markdown
Member

I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed.

@StephanTLavavej

Stephan T. Lavavej (StephanTLavavej) commented Sep 14, 2023

Copy link
Copy Markdown
Member

Thanks for scouting out LLVM 17! 🏞️ 🥾 😻

@CaseyCarterCasey Carter (CaseyCarter) mentioned this pull request Jan 30, 2024
Open
@frederick-vs-jaA. Jiang (frederick-vs-ja) mentioned this pull request May 24, 2024
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@StephanTLavavejStephan T. Lavavej (StephanTLavavej)StephanTLavavej approved these changes
+2 more reviewers
@frederick-vs-jaA. Jiang (frederick-vs-ja)frederick-vs-ja left review comments
@strega-nil-msnicole mazzuca (strega-nil-ms)strega-nil-ms approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@StephanTLavavejStephan T. Lavavej (StephanTLavavej)

Labels

enhancementSomething can be improved

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@CaseyCarter@StephanTLavavej@frederick-vs-ja@strega-nil-ms