Skip to content

Add C4868 to _STL_DISABLED_WARNINGS #4067

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Stephan T. Lavavej (StephanTLavavej) merged 3 commits into from
Oct 4, 2023
Merged

Add C4868 to _STL_DISABLED_WARNINGS #4067

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d5b12d1
Add C4868 to _STL_DISABLED_WARNINGS
tiagomacarios Oct 3, 2023
3d41a2a
`<execution>` doesn't need to disable 4868 anymore.
StephanTLavavej Oct 3, 2023
a67aef1
Record that C4868 is an off-by-default `/Wall` warning.
StephanTLavavej Oct 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 0 additions & 12 deletions stl/inc/execution
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1867,9 +1867,6 @@ struct _Static_partitioned_mismatch3 {
}
};

#pragma warning(push)
#pragma warning(disable : 4868) // compiler may not enforce left-to-right evaluation order
// in braced initializer list (/Wall)
_EXPORT_STD template <class _ExPo, class _FwdIt1, class _FwdIt2, class _Pr,
_Enable_if_execution_policy_t<_ExPo> /* = 0 */>
_NODISCARD pair<_FwdIt1, _FwdIt2> mismatch(
Expand Down Expand Up @@ -1911,7 +1908,6 @@ _NODISCARD pair<_FwdIt1, _FwdIt2> mismatch(
_Seek_wrapped(_First1, _Result.first);
return {_First1, _First2};
}
#pragma warning(pop)

_EXPORT_STD template <class _ExPo, class _FwdIt1, class _FwdIt2, class _Pr,
_Enable_if_execution_policy_t<_ExPo> /* = 0 */>
Expand Down Expand Up @@ -2396,9 +2392,6 @@ struct _Static_partitioned_binary_transform2 {
}
};

#pragma warning(push)
#pragma warning(disable : 4868) // compiler may not enforce left-to-right evaluation order
// in braced initializer list (/Wall)
_EXPORT_STD template <class _ExPo, class _FwdIt1, class _FwdIt2, class _FwdIt3, class _Fn,
_Enable_if_execution_policy_t<_ExPo> /* = 0 */>
_FwdIt3 transform(_ExPo&&, const _FwdIt1 _First1, const _FwdIt1 _Last1, const _FwdIt2 _First2, _FwdIt3 _Dest,
Expand Down Expand Up @@ -2443,7 +2436,6 @@ _FwdIt3 transform(_ExPo&&, const _FwdIt1 _First1, const _FwdIt1 _Last1, const _F
return _Dest;
}
}
#pragma warning(pop)

_EXPORT_STD template <class _ExPo, class _FwdIt, class _Ty, _Enable_if_execution_policy_t<_ExPo> /* = 0 */>
void replace(_ExPo&& _Exec, const _FwdIt _First, const _FwdIt _Last, const _Ty& _Oldval, const _Ty& _Newval) noexcept
Expand Down Expand Up @@ -4162,9 +4154,6 @@ struct _Static_partitioned_transform_reduce_binary2 { // transform-reduction tas
}
};

#pragma warning(push)
#pragma warning(disable : 4868) // compiler may not enforce left-to-right evaluation order
// in braced initializer list (/Wall)
_EXPORT_STD template <class _ExPo, class _FwdIt1, class _FwdIt2, class _Ty, class _BinOp1, class _BinOp2,
_Enable_if_execution_policy_t<_ExPo> /* = 0 */>
_NODISCARD _Ty transform_reduce(_ExPo&&, _FwdIt1 _First1, _FwdIt1 _Last1, _FwdIt2 _First2, _Ty _Val, _BinOp1 _Reduce_op,
Expand Down Expand Up @@ -4219,7 +4208,6 @@ _NODISCARD _Ty transform_reduce(_ExPo&&, _FwdIt1 _First1, _FwdIt1 _Last1, _FwdIt
_Get_unwrapped_n(_First2, _Idl_distance<_FwdIt1>(_UFirst1, _ULast1)), _STD move(_Val), _Pass_fn(_Reduce_op),
_Pass_fn(_Transform_op));
}
#pragma warning(pop)

template <class _FwdIt, class _Ty, class _BinOp, class _UnaryOp>
struct _Static_partitioned_transform_reduce2 { // transformed reduction task scheduled on the system thread pool
Expand Down
5 changes: 3 additions & 2 deletions stl/inc/yvals_core.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -793,6 +793,7 @@
// warning C4702: unreachable code
// warning C4793: function compiled as native
// warning C4820: 'N' bytes padding added after data member 'meow' (/Wall)
// warning C4868: compiler may not enforce left-to-right evaluation order in braced initializer list (/Wall)
// warning C4988: variable declared outside class/function scope (/Wall /d1WarnOnGlobals)
// warning C5026: move constructor was implicitly defined as deleted (/Wall)
// warning C5027: move assignment operator was implicitly defined as deleted (/Wall)
Expand All @@ -805,8 +806,8 @@
// clang-format off
#define _STL_DISABLED_WARNINGS \
4180 4412 4455 4494 4514 4574 4582 4583 4587 4588 \
4619 4623 4625 4626 4643 4648 4702 4793 4820 4988 \
5026 5027 5045 5220 6294 \
4619 4623 4625 4626 4643 4648 4702 4793 4820 4868 \
Comment thread
StephanTLavavej marked this conversation as resolved.
4988 5026 5027 5045 5220 6294 \
_STL_DISABLED_WARNING_C4577 \
_STL_DISABLED_WARNING_C4984 \
_STL_DISABLED_WARNING_C5053 \
Expand Down